Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/servicegraph] Unit test failures on Windows #33679

Open
crobert-1 opened this issue Jun 20, 2024 · 5 comments
Open

[connector/servicegraph] Unit test failures on Windows #33679

crobert-1 opened this issue Jun 20, 2024 · 5 comments

Comments

@crobert-1
Copy link
Member

Component(s)

connector/servicegraph

Describe the issue you're reporting

Failing CI/CD action

Failure output:

=== Failed
=== FAIL: . TestVirtualNodeServerLabels (0.11s)
    logger.go:146: 2024-06-20T17:45:57.553Z	INFO	Started servicegraphconnector
    connector_test.go:515: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:515
make[2]: *** [../../Makefile.Common:126: test] Error 1
        	Error:      	Condition never satisfied
        	Test:       	TestVirtualNodeServerLabels
    logger.go:146: 2024-06-20T17:45:57.657Z	INFO	Shutting down servicegraphconnector
    connector_test.go:521: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:521
make[1]: *** [Makefile:179: connector/servicegraphconnector] Error 2
        	Error:      	"0" is not greater than or equal to "1"
make[1]: *** Waiting for unfinished jobs....
        	Test:       	TestVirtualNodeServerLabels

=== FAIL: . TestVirtualNodeClientLabels (0.11s)
    logger.go:146: 2024-06-20T17:45:57.[658](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9601826617/job/26481239827#step:6:659)Z	INFO	Started servicegraphconnector
    connector_test.go:559: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:559
        	Error:      	Condition never satisfied
        	Test:       	TestVirtualNodeClientLabels
    logger.go:146: 2024-06-20T17:45:57.766Z	INFO	Shutting down servicegraphconnector
    connector_test.go:565: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:565
        	Error:      	"0" is not greater than or equal to "1"
        	Test:       	TestVirtualNodeClientLabels

=== FAIL: . TestVirtualNodeClientLabels (re-run 1) (0.11s)
    logger.go:146: 2024-06-20T17:46:09.813Z	INFO	Started servicegraphconnector
    connector_test.go:559: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:559
        	Error:      	Condition never satisfied
        	Test:       	TestVirtualNodeClientLabels
    logger.go:146: 2024-06-20T17:46:09.920Z	INFO	Shutting down servicegraphconnector
    connector_test.go:565: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:565
        	Error:      	"0" is not greater than or equal to "1"
        	Test:       	TestVirtualNodeClientLabels
@crobert-1 crobert-1 added the needs triage New item requiring triage label Jun 20, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@t00mas
Copy link
Contributor

t00mas commented Jun 20, 2024

I'll have a look at this

@crobert-1
Copy link
Member Author

@pjanotti
Copy link
Contributor

pjanotti commented Jul 2, 2024

Currently skipping the offending tests on Windows via #33837

Copy link
Contributor

github-actions bot commented Sep 2, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants