Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheus] Support exporting min/max for histogram metrics #33645

Closed
xiepuhuan opened this issue Jun 19, 2024 · 4 comments
Closed
Labels

Comments

@xiepuhuan
Copy link

Component(s)

exporter/prometheus

Is your feature request related to a problem? Please describe.

I don't pay attention to histogram bucket, but I want to know histogram max/min

Describe the solution you'd like

I don't pay attention to histogram bucket, but I want to know histogram max/min

Describe alternatives you've considered

No response

Additional context

No response

@xiepuhuan xiepuhuan added enhancement New feature or request needs triage New item requiring triage labels Jun 19, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

dashpole commented Dec 3, 2024

The prometheus histogram data model does not include a min and max, so there isn't a good place for us to put it within the histogram. We could create a new timeseries for the min and max, however, the min and max are known to be basically useless for cumulative histograms. For delta histograms, the min and max are the min and max of the most recent interval, which is helpful for showing spikes over time. For cumulative histograms, the min and max are the min and max for all time. For long-lived (> 1 hour) applications, the min and max rarely change in a meaningful way.

Regardless, this change would need a spec issue and a change to the prometheus specification before we can implement it here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md.

@dashpole dashpole closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants