Validate failed to catch invalid value in resource processor

[EddieEldridge]

Component(s)

internal/core

What happened?

Description

The validate flag failed to catch an invalid configuration

Steps to Reproduce

resource/attributes_add:
    attributes:
    - key: service.layer
      value: null  # Problem value
      action: upsert

Expected Result

The validate command would flag this as an illegal value

Actual Result

The Collector failed to start

Error: failed to build pipelines: failed to create "resource/attributes_add" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for X-th action

Collector version

0.94.0

Environment information

No response

OpenTelemetry Collector configuration

resource/attributes_add:
    attributes:
    - key: service.layer
      value: null  # Problem value
      action: upsert

Log output

Error: failed to build pipelines: failed to create "resource/attributes_add" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for X-th action

Additional context

No response

[github-actions]

Pinging code owners:

• internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[EddieEldridge]

Still relevant and still important imo. Can be quite easy to resolve a null value.

[github-actions]

Pinging code owners for processor/attributes: @boostchicken. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

I'm not sure this is invalid. Empty values exist. But we can certainly look into it and make sure validation catches, depending what codeowners think.

[github-actions]

Pinging code owners for processor/resource: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[EddieEldridge]

I'm not sure this is invalid. Empty values exist. But we can certainly look into it and make sure validation catches, depending what codeowners think.

If the Collector refuses to start with it present surely that's "invalid"? Or maybe I am misunderstanding your comment.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/attributes: @boostchicken
• processor/resource: @dmitryax
• internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.