Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No AggTemp column in otel.otel_metrics_histogram Table #33424

Closed
jwafle opened this issue Jun 7, 2024 · 3 comments
Closed

No AggTemp column in otel.otel_metrics_histogram Table #33424

jwafle opened this issue Jun 7, 2024 · 3 comments
Labels
bug Something isn't working exporter/clickhouse needs triage New item requiring triage

Comments

@jwafle
Copy link
Contributor

jwafle commented Jun 7, 2024

Component(s)

exporter/clickhouse

What happened?

Description

The otel.otel_metrics_histogram table has no AggTemp column, so it is impossible to tell the difference between Delta and Cumulative metrics stored in this table.

Steps to Reproduce

Expected Result

AggTemp in the otel.otel_metrics_sum table is stored from the metric.AggregationTemporality(). The same should be the case for otel.otel_metrics_histogram

Actual Result

No AggTemp column in otel.otel_metrics_histogram.

Collector version

v0.102.0

Environment information

No environment information necessary. This affects all environments.

OpenTelemetry Collector configuration

Any implementation of the clickhouseexporter would have this bug.

Log output

N/A

Additional context

Current otel.otel_metrics_histogram schema: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/clickhouseexporter/internal/histogram_metrics.go#L21-L60

Current otel.otel_metrics_sum schema: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/clickhouseexporter/internal/sum_metrics.go#L21-L57

I am planning on opening a PR to fix this as well.

@jwafle jwafle added bug Something isn't working needs triage New item requiring triage labels Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@SpencerTorres
Copy link
Member

Appreciate the explanation in this issue, hope to get the PR merged soon. Thanks!

dmitryax pushed a commit that referenced this issue Jun 19, 2024
**Description:**
- Addresses lack of temporality in stored data model for `Histogram` and
`Exponential Histogram` metric types in Clickhouse exporter

**Link to tracking Issue:** #33424
@dmitryax
Copy link
Member

Resolved by #33425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/clickhouse needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

3 participants