Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/receivercreator] Add ability to use endpoint as different config options #33187

Closed
crobert-1 opened this issue May 22, 2024 · 4 comments
Labels
enhancement New feature or request needs triage New item requiring triage receiver/receivercreator

Comments

@crobert-1
Copy link
Member

crobert-1 commented May 22, 2024

Component(s)

receiver/receivercreator

Describe the issue you're reporting

The receiver creator uses configured rules to try to match endpoints passed in from observer extensions. If an endpoint's details match a rule, the receiver creator will then create a receiver to target that endpoint.

The receiver creator attempts to create the target receiver with an endpoint config attribute. If successful, the endpoint is set, otherwise the target receiver's default configuration is used. Relevant logic here.

The enhancement that I'm proposing is to be able to parse a given endpoint in the receiver creator to try to set different configuration options in the target receiver's config. The referenced method above could be modified to try to parse the end point into a host and port, then try to set different config options in a receiver with those. The SQL Server receiver, for example, uses server and port, and is the receiver I'm currently working to add this functionality for.

@crobert-1 crobert-1 added the needs triage New item requiring triage label May 22, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for receiver/receivercreator: @rmfitzpatrick. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@samiura
Copy link
Contributor

samiura commented May 22, 2024

👍🏽

@crobert-1
Copy link
Member Author

Looks like I was a bit premature with filing an issue here. The receiver creator actually exposes host and port as env variables, so the target receiver's specified config can simply use these the same way endpoint is used for different config options. Closing as there's nothing to do here 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/receivercreator
Projects
None yet
Development

No branches or pull requests

2 participants