Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheusremotewriteexporter] Allow to set batch_send_deadline #32891

Closed
pfrayer opened this issue May 7, 2024 · 3 comments
Closed

Comments

@pfrayer
Copy link

pfrayer commented May 7, 2024

Component(s)

exporter/prometheusremotewrite

Is your feature request related to a problem? Please describe.

In a standalone Prometheus remote-write's configuration, you can set up a queue_config with many options. For instance:

queue_config:
  capacity: 3000
  max_shards: 100
  min_shards: 1
  max_samples_per_send: 1000
  batch_send_deadline: 30s
  min_backoff: 1s
  max_backoff: 60s
  retry_on_http_429: true

Currently in the prometheusremotewriteexporter you can only set the following:

remote_write_queue:
  enabled: true
  queue_size: 3000
  num_consumers: 10
retry_on_failure:
  enabled: true

As we can't set the batch_send_deadline option, the prometheusremotewriteexporter seems to perform remote-writes only each 60sec (can't find where it's set).
If the remote-write backend have less HA replicas than the number of prometheusremotewriteexporter pushing replicas, and the remote-write backend try to elect a new replicas leader less than each 60sec, the HA backend will pick a new leader and the send metrics will be dropped.

Describe the solution you'd like

Be able to define the remote-write frequency

Describe alternatives you've considered

No response

Additional context

No response

@pfrayer pfrayer added enhancement New feature or request needs triage New item requiring triage labels May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant