-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of storage policy for clickhouse exporter #32816
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Looks goods to add new config field support extra setting. hi, @SpencerTorres what is your ideal and could have time to implement it? |
ClickHouse has a lot of options when configuring a table, too many for us to reasonably keep up with and add to the exporter config. Instead, I recommend using the new When you set If you need an example of what DDL the exporter would run, you can check the |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
See my above response on controlling these specific properties. Table creation can now be fully managed by the user and is the recommended way to run the DDL. We can close this @crobert-1 |
Component(s)
exporter/clickhouse
Is your feature request related to a problem? Please describe.
The exporter creates a new database and table, but when a specific storage policy is required for the table, this can not be set on table creation by the exporter.
Describe the solution you'd like
Add an option in de clickhouse_exporter config for allowing to set a custom storage policy on table create
Describe alternatives you've considered
It can be set afterwards in clickhouse, but this requires you to include the current storage policy and move data to the new storage before disabling the 'old' storage policy
Additional context
See the final SETTINGS line for table creation
The text was updated successfully, but these errors were encountered: