Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can tailsamplingprocessor be configured to take the "sampled" flag (from trace-flags) into account? #32763

Open
jpkrohling opened this issue Apr 30, 2024 Discussed in #32495 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed processor/tailsampling Tail sampling processor

Comments

@jpkrohling
Copy link
Member

Discussed in #32495

Originally posted by BatmanAoD April 17, 2024
I have a service that is sending trace data to an OTEL collector, where it is sampled by the tailsamplingprocessor before being sent to Honeycomb. There is a client that does head-sampling, then sends its trace data directly to Honeycomb. I'd like to ensure that any calls that come from a client using head-sampling get sampled, i.e. that the sampled flag from the TraceContext's trace-flags is respected.

I can't tell if this is possible from the documentation of tailsamplingprocessor. @jpkrohling, in this comment, it sounds like you're saying that it's possible to use the sampled flag, but the README says:

This processor must be placed in pipelines after any processors that rely on context, e.g. k8sattributes. It reassembles spans into new batches, causing them to lose their original context.

Does this mean that the tailsamplingprocessor doesn't receive the original trace context, including the traceparent header?

@jpkrohling jpkrohling self-assigned this Apr 30, 2024
@jpkrohling jpkrohling added the processor/tailsampling Tail sampling processor label Apr 30, 2024
Copy link
Contributor

Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 1, 2024
@jpkrohling jpkrohling added enhancement New feature or request help wanted Extra attention is needed and removed Stale labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 9, 2024
@jpkrohling jpkrohling removed the Stale label Sep 9, 2024
@mikocot
Copy link

mikocot commented Sep 12, 2024

what is the blocker for this improvement? Is it conflicting with some existing changes or just needs additional cases to be taken into account?

@jpkrohling
Copy link
Member Author

@mikocot, if you have a PR lined up, I'll review it.

@mikocot
Copy link

mikocot commented Sep 20, 2024

I don't, I'm not familiar with the code base, just wondering if that's something that is not implemented due to lack of resources, conflicting with some existing code, or it's not considered even the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed processor/tailsampling Tail sampling processor
Projects
None yet
Development

No branches or pull requests

2 participants