-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can tailsamplingprocessor
be configured to take the "sampled" flag (from trace-flags
) into account?
#32763
Comments
Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
what is the blocker for this improvement? Is it conflicting with some existing changes or just needs additional cases to be taken into account? |
@mikocot, if you have a PR lined up, I'll review it. |
I don't, I'm not familiar with the code base, just wondering if that's something that is not implemented due to lack of resources, conflicting with some existing code, or it's not considered even the right approach. |
Discussed in #32495
Originally posted by BatmanAoD April 17, 2024
I have a service that is sending trace data to an OTEL collector, where it is sampled by the
tailsamplingprocessor
before being sent to Honeycomb. There is a client that does head-sampling, then sends its trace data directly to Honeycomb. I'd like to ensure that any calls that come from a client using head-sampling get sampled, i.e. that thesampled
flag from the TraceContext'strace-flags
is respected.I can't tell if this is possible from the documentation of
tailsamplingprocessor
. @jpkrohling, in this comment, it sounds like you're saying that it's possible to use thesampled
flag, but the README says:Does this mean that the
tailsamplingprocessor
doesn't receive the original trace context, including thetraceparent
header?The text was updated successfully, but these errors were encountered: