Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] When using mapping.mode: ecs, drop scalar fields in case of object/scalar conflicts #32745

Closed
ycombinator opened this issue Apr 29, 2024 · 8 comments

Comments

@ycombinator
Copy link
Contributor

ycombinator commented Apr 29, 2024

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

When mapping.mode: ecs is used, certain OTel + SemConv fields are converted to ECS fields to ensure that dashboards and other assets currently using ECS fields continue to work. Due to this conversion, it's possible to run into object/scalar conflicts in the source field set, for example, {"foo": 1, "foo.bar": 2}.

Describe the solution you'd like

In such cases, we should drop the scalar value. For example, {"foo": 1, "foo.bar": 2} should be converted to {"foo": { "bar": 2}}.

Describe alternatives you've considered

No response

Additional context

No response

@ycombinator ycombinator added enhancement New feature or request needs triage New item requiring triage labels Apr 29, 2024
@ycombinator
Copy link
Contributor Author

cc: @axw

Copy link
Contributor

Pinging code owners for exporter/elasticsearch: @JaredTan95 @ycombinator @carsonip. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

This was filed by a code owner, so I'm removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 30, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 1, 2024
@axw
Copy link
Contributor

axw commented Jul 1, 2024

This is still relevant. I think it's only relevant with the config dedup: false, but need to confirm that. I'll take a stab at it as part of #33776

@github-actions github-actions bot removed the Stale label Jul 1, 2024
@axw
Copy link
Contributor

axw commented Jul 2, 2024

It's only relevant in the case of dedup: false, which I'm removing in #33776. I've added a test case to that PR.

The existing behaviour is that {"foo": 1, "foo.bar": 2} will be translated to {"foo": {"value": 1, "bar": 2}} with de-dotting. If the input is rather {"foo": 1, "foo.value": 2}, then the result will be {"foo": {"value": 2}}.

I'm not a fan of this magical ".value" addition, but inclined to leave it alone for now.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants