Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/vmware/govmomi to v0.37.0 causes build failures #32453

Closed
codeboten opened this issue Apr 16, 2024 · 7 comments
Closed
Assignees

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/vcenter

Describe the issue you're reporting

See #32436

=== Failed
=== FAIL: . TestScrape (0.01s)
    scraper_test.go:58: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:58
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:33
        	Error:      	Received unexpected error:
        	            	unable to get datacenter lists: POST "/sdk": 404 Not Found
        	Test:       	TestScrape

=== FAIL: . TestScrape_TLS (0.02s)
    scraper_test.go:58: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:58
make[2]: *** [../../Makefile.Common:126: test] Error 1
make[1]: *** [Makefile:165: receiver/vcenterreceiver] Error 2
make: *** [Makefile:113: gotest] Error 2
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:51
        	Error:      	Received unexpected error:
        	            	unable to get datacenter lists: POST "/sdk": 404 Not Found
        	Test:       	TestScrape_TLS

=== FAIL: . TestScrape (re-run 1) (0.01s)
    scraper_test.go:58: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:58
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:33
        	Error:      	Received unexpected error:
        	            	unable to get datacenter lists: POST "/sdk": 404 Not Found
        	Test:       	TestScrape

=== FAIL: . TestScrape_TLS (re-run 1) (0.02s)
    scraper_test.go:58: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:58
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/vcenterreceiver/scraper_test.go:51
        	Error:      	Received unexpected error:
        	            	unable to get datacenter lists: POST "/sdk": 404 Not Found
        	Test:       	TestScrape_TLS

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@schmikei @StefanKurek, can either of you please take this? This is blocking other PRs

@StefanKurek
Copy link
Contributor

@djaglowski I should be able to take a look

@djaglowski
Copy link
Member

Thanks @StefanKurek!

@StefanKurek
Copy link
Contributor

@djaglowski So I "think" I at least have some idea where to start looking. So at the very least, with the new govmomi update, I know that this is now using a new type of call RetrievePropertiesEx as the old one RetrieveProperties was deprecated as of version 4.1 of the API.

This results in the mock server not returning a correct response to seed the finder with a default datacenter, and then some (all?) consecutive client calls will fail (as they are expecting this).

Also, "all" the mock responses may need to be updated to RetrievePropertiesExResponse types rather than just for this one call. I'm not completely sure of this though, and would require more digging (would also probably become obvious after fixing that initial mocked response).

I don't have time to work on this immediately. It may be a few days, but I will try to come back to it soon.

djaglowski pushed a commit that referenced this issue Jun 28, 2024
…tests (#33721)

**Description:** <Describe what has changed.>
Updates govmomi library for `vcenterreceiver` to v0.37.3. This makes use
of the `RetrievePropertiesEx` function as `RetrieveProperties` is
deprecated. All of the related unit tests had to be redone to consider
this.

There are no customer facing changes with this.

**Link to tracking Issue:** <Issue number if applicable>
#32453 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests/integration tests pass. Manual check against live
environment.

**Documentation:** <Describe the documentation added.>
No customer facing changes.
@StefanKurek
Copy link
Contributor

We should be able to close this now

@djaglowski
Copy link
Member

Resolved by #33721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants