-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[statsdreceiver] fail to parse payloads with empty tag data #32337
Comments
Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
**Description:** we see some payloads with completely empty tags, which we can safely ignore. This is already handled by the receiver, but we did not have a test for it. Close #32337 **Testing:** adds simple test to receiver --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Component(s)
receiver/statsd
What happened?
Description
sending a statsd payload w/ a completely empty tag causes a panic.
Steps to Reproduce
send a payload like
test.metric:42|c|#,,,
- note the 0-length strings in between the commas denoting empty tags. dogstatsd clients sometimes are happy to send tags like this; i have mostly seen it in the go client.Expected Result
no panic, collector is calm and collected
Actual Result
panic
Collector version
v0.96.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: