Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/failover] Ability to skip max_retries for levels #32031

Closed
sinkingpoint opened this issue Mar 28, 2024 · 2 comments
Closed

[connector/failover] Ability to skip max_retries for levels #32031

sinkingpoint opened this issue Mar 28, 2024 · 2 comments
Labels
connector/failover enhancement New feature or request

Comments

@sinkingpoint
Copy link
Contributor

sinkingpoint commented Mar 28, 2024

Is your feature request related to a problem? Please describe.

The failover connector currently has max_retries setting that allows setting a maximum number of retries before completely removing an exporter from the pool. In our case, our high priority receiver might be out for hours, or even days, so there's no real setting that makes sense for us.

Describe the solution you'd like

We should have a way to disable the max_retries setting so that the connector will continue to poll the higher priority receivers, regardless of how long they have been out. Other components use a magic value of 0 for this purpose, but in the failover connector a max_retries of 0 automatically rejects every pipeline and errors.

Describe alternatives you've considered

The alternative is just to set this to a very large value, potentially calculated based off of the retry time, and some maximum acceptable length of time, but this just sets a time bomb

@sinkingpoint sinkingpoint changed the title [connector/failoverconnector] Ability to skip max_retries for levels [connector/failover] Ability to skip max_retries for levels Mar 28, 2024
@TylerHelmuth TylerHelmuth added the enhancement New feature or request label Mar 28, 2024
@TylerHelmuth TylerHelmuth transferred this issue from open-telemetry/opentelemetry-collector Mar 28, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for connector/failover: @akats7 @djaglowski @fatsheep9146. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/failover enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants