-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/prometheus] Wait for final scrape during collector shutdown #31887
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/prometheus
Is your feature request related to a problem? Please describe.
Prometheus may miss scraping a collector's metrics while the collector is shutting down
Describe the solution you'd like
The prometheus exporter could block during
Shutdown
until it's scraped or a configurable timeout passesDescribe alternatives you've considered
Possibly artificially delaying the shutdown of the collector works, but it sounds hacky
Additional context
I could implement this if no one else is interested
From looking at the code, i'm picturing the
/metrics
http handler writing to a channel once theShutdown
code sets aisShuttingDown
flag, and then theShutdown
code blocking on reading that channelThe text was updated successfully, but these errors were encountered: