Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loadbalancingexporter] provide timeout to k8s resolver #31757

Closed
grzn opened this issue Mar 14, 2024 · 3 comments · Fixed by #31904
Closed

[loadbalancingexporter] provide timeout to k8s resolver #31757

grzn opened this issue Mar 14, 2024 · 3 comments · Fixed by #31904
Assignees
Labels

Comments

@grzn
Copy link
Contributor

grzn commented Mar 14, 2024

Component(s)

No response

Is your feature request related to a problem? Please describe.

With the default k8s client so sometimes get timeout errors like this

E0314 08:24:19.610919       1 reflector.go:147] k8s.io/client-go@v0.28.4/tools/cache/reflector.go:229: Failed to watch *v1.Pod: failed to list *v1.Pod: Get "https://172.20.0.1:443/api/v1/pods?fieldSelector=spec.nodeName%3Dip-10-0-17-162.eu-north-1.compute.internal&resourceVersion=4141611754": dial tcp 172.20.0.1:443: i/o timeout

Describe the solution you'd like

it would be nice to configure the k8s client with a larger timeout.

Describe alternatives you've considered

No response

Additional context

No response

@grzn grzn added enhancement New feature or request needs triage New item requiring triage labels Mar 14, 2024
Copy link
Contributor

Pinging code owners for exporter/loadbalancing: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Makes sense to me, especially since other resolvers are able to have their own timeout specified.

I investigated, it looks pretty straightforward to implement this.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Mar 14, 2024
@jpkrohling
Copy link
Member

Even though I don't think I would increase the timeout in this case, I agree that users should be able to set a timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants