Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/jmx] Ability to discovery jmx endpoints dynamically #31599

Open
neo-waiariki-koia opened this issue Mar 5, 2024 · 7 comments
Open
Labels
enhancement New feature or request receiver/jmx JMX Receiver Stale

Comments

@neo-waiariki-koia
Copy link

Component(s)

receiver/jmx

Is your feature request related to a problem? Please describe.

At the moment, the endpoint for jmx receiver has to be hardcoded. Unfortunately, for my use case, this isn't feasible. I was hoping some sort of service discovery mechanism could be implemented to find endpoints dynamically? The prometheus receiver has this and, although different, Datadog agents can facilitate similar functionality.

Describe the solution you'd like

I'd like for the ability to discover jmx endpoints dynamically within a Kubernetes cluster. This could be done by filtering pods based on fields, labels or annotations.

Describe alternatives you've considered

No response

Additional context

No response

@neo-waiariki-koia neo-waiariki-koia added enhancement New feature or request needs triage New item requiring triage labels Mar 5, 2024
@github-actions github-actions bot added the receiver/jmx JMX Receiver label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95
Copy link
Member

From your description, I think it might be more appropriate to put this requirement into otel-operator?

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Mar 22, 2024
@joerg
Copy link

joerg commented Mar 28, 2024

+1 for that feature. Currently, fetching other metrics than the built in ones requires building a custom jar file (see #17072) which is an unreasonable amount of overhead for just a list of metrics to gather.
In my case, I need to gather metrics from the Atlassian tools (e.g. Jira https://confluence.atlassian.com/adminjiraserver/live-monitoring-using-the-jmx-interface-939707304.html) which would require me to:

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 28, 2024
@hughesjj
Copy link
Contributor

Hey, so there are observer that you can use with the receiver creator, but it doesn't introspect whether it's a jmx endpoint or not. We could try figuring out if there's any indicators to make it more likely to determine whether an endpoint is jmx, or add some special observer for such.

@hughesjj
Copy link
Contributor

hughesjj commented Jul 22, 2024

However, this doesn't resolve the problem with the jmx-metrics-gatherer not supporting arbitrary queries. There's some history on that topic, will update as I find the artifacts. TL;DR inclusion of jmx receiver in this distro was predicated on not allowing arbitrary code to be run

Updates:

We can talk about this more in a SIG meeting or on the CNCF slack (invite) if you prefer

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/jmx JMX Receiver Stale
Projects
None yet
Development

No branches or pull requests

4 participants