Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tail-sampling processor #31580

Open
1 of 4 tasks
jpkrohling opened this issue Mar 5, 2024 · 8 comments
Open
1 of 4 tasks

Refactor tail-sampling processor #31580

jpkrohling opened this issue Mar 5, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request processor/tailsampling Tail sampling processor Stale

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Mar 5, 2024

Component(s)

processor/tailsampling

Is your feature request related to a problem? Please describe.

The tail-sampling processor has been there for a few years now, and despite being relatively popular, it hasn't changed much over the years besides adding new policies. There are a few things I always wanted to do but didn't have the time or motivation, and it would be a good idea to list them here in case we have volunteers to work on them.

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

No response

@jpkrohling
Copy link
Member Author

cc @kentquirk

@jpkrohling jpkrohling removed the needs triage New item requiring triage label Mar 5, 2024
@jpkrohling jpkrohling self-assigned this Mar 5, 2024
@jpkrohling jpkrohling added the processor/tailsampling Tail sampling processor label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kentquirk
Copy link
Member

Yes, AND, I also think that the binary keep/drop structure is a problem because it's not adequately composable if the probability of the decision matters to you. This proposal is related but I'm not sure yet if it actually applies.

@jiekun
Copy link
Member

jiekun commented Mar 14, 2024

I'm interested in #31584 if we could have more info / context / expectation :P

@jpkrohling
Copy link
Member Author

I think this is also relevant for the discussion: #25122

@jpkrohling
Copy link
Member Author

Related: #31498

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/tailsampling Tail sampling processor Stale
Projects
None yet
Development

No branches or pull requests

3 participants