Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File storage extension - Garbage collect old data files #3149

Open
djaglowski opened this issue Apr 16, 2021 · 4 comments
Open

File storage extension - Garbage collect old data files #3149

djaglowski opened this issue Apr 16, 2021 · 4 comments
Labels
extension/storage/filestorage help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed
Milestone
Logs Support, Pha...

Comments

@djaglowski
Copy link
Member

djaglowski commented Apr 16, 2021 •
edited
Loading

For the future: here we have an opportunity to to garbage collect files that don't have clients (I am not sure we have a good place to do it at startup).

Originally posted by @tigrannajaryan in #3087 (comment)
@djaglowski djaglowski self-assigned this Apr 16, 2021
@djaglowski djaglowski mentioned this issue Apr 16, 2021
Merged
@tigrannajaryan tigrannajaryan added the help wanted Extra attention is needed label Apr 16, 2021
@tigrannajaryan tigrannajaryan added this to the Logs Support, Phase 2 milestone Apr 16, 2021
@djaglowski djaglowski removed their assignment May 11, 2021
@djaglowski djaglowski mentioned this issue May 24, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@djaglowski djaglowski added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Nov 4, 2022
@github-actions
Copy link
Contributor

Pinging code owners for extension/storage/filestorage: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Dec 9, 2023

@djaglowski I believe this is now fixed with your extensive changes to stanza, is that correct?

@atoulme
Copy link
Contributor

atoulme commented Dec 9, 2023 •
edited
Loading

I might be wrong about this - in any case I'm not sure if this issue is still valid.

Never mind, I see the TODO

opentelemetry-collector-contrib/extension/storage/filestorage/extension.go

Line 49 in 6e02e73

// TODO clean up data files that did not have a client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension/storage/filestorage help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
Logs Support, Phase 2
Development

No branches or pull requests
3 participants
@atoulme @tigrannajaryan @djaglowski