Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Improve OTTL Docs #31387

Open
6 tasks
TylerHelmuth opened this issue Feb 22, 2024 · 8 comments
Open
6 tasks

[pkg/ottl] Improve OTTL Docs #31387

TylerHelmuth opened this issue Feb 22, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed pkg/ottl priority:p2 Medium processor/filter Filter processor processor/transform Transform processor

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Feb 22, 2024

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

OTTL docs exist, but I get the sense that they are sufficient. We get lots and lots of questions in the CNCF slack and in Github about how to use OTTL, especially in the filterprocessor.

Describe the solution you'd like

We should do a wholistic review of our docs, making sure that they are as user-focused as possible. While the API/Grammar of OTTL is important, it isn't as important as directing users to how to write statements in their configs.

Things to review:

  • Func documentation
  • Examples
  • Documentation of important language features, such as passing Converters as params, arithmetic, where clauses, etc.
  • Precence on opentelemetry.io
  • Transformprocessor readme
  • Filterprocessor readme.
@TylerHelmuth TylerHelmuth added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p2 Medium processor/filter Filter processor processor/transform Transform processor pkg/ottl labels Feb 22, 2024
Copy link
Contributor

Pinging code owners for processor/filter: @TylerHelmuth @boostchicken. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@TylerHelmuth TylerHelmuth added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Apr 23, 2024
@bixu
Copy link

bixu commented Jul 23, 2024

Things to review:

  • Func documentation
  • Examples
  • Documentation of important language features, such as passing Converters as params, arithmetic, where clauses, etc.
  • Precence on opentelemetry.io
  • Transformprocessor readme
  • Filterprocessor readme.

To these I would add:

  • High-level explanation of Contexts and and their relationships (ie accessing values across context boundaries)

While OTTL feature set feels pretty rich atm, it remains hard to learn for new practitioners due to the sparseness of docs. Still, I envision a future where we use OTTL for all of our telemetry processing at $job. Great docs would speed up our adoption.

@TylerHelmuth
Copy link
Member Author

I think #29017 helps with the context problem.

@bixu
Copy link

bixu commented Aug 12, 2024

@TylerHelmuth, I'm interested in taking a crack at this. Do we have an example of docs elsewhere in the project that would be a good example to follow? If not, can I submit a draft PR to get early feedback?

@TylerHelmuth
Copy link
Member Author

The stanza docs are pretty good.

I'm pretty happy with our function docs, but unhappy with how we explain what a transform context means. I would also like to see a ton of this stuff be on the opentelemetry.io site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed pkg/ottl priority:p2 Medium processor/filter Filter processor processor/transform Transform processor
Projects
None yet
Development

No branches or pull requests

2 participants