[receiver/azuremonitor] Handle errors; don't ignore them

[nslaughter]

Component(s)

receiver/azuremonitor

What happened?

Description

Code currently fails silently when getting clients from Azure SDK for metrics and metric definitions.

Steps to Reproduce

Read the code called by start method of scraper. It currently holes errors when instantiating SDK clients the scraper uses.

Look at getArmClient and azureScraper.GetMetricsValuesClient.

Expected Result

Handle errors.

Actual Result

Ignores errors.

Collector version

v0.94.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

# N/A

Log output

N/A

Additional context

N/A

[github-actions]

Pinging code owners:

• receiver/azuremonitor: @altuner @codeboten

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Agreed, the errors shouldn't be hidden and ignored. I checked and found this has been the functionality since this component was introduced, but there's no comment as to why they're ignored.

I see this is in the call stack of every scrape call, so either an error here is pretty impactful, or it would spam logs. I'm not familiar enough with this receiver to know which is true.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/azuremonitor: @nslaughter @codeboten

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/azuremonitor: @nslaughter @codeboten

See Adding Labels via Comments if you do not have permissions to add labels yourself.