Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azuremonitorexporter] Seems to not respect semantic convention on http field for mapping #31255

Closed
aygalinc opened this issue Feb 14, 2024 · 8 comments
Labels
bug Something isn't working exporter/azuremonitor needs triage New item requiring triage

Comments

@aygalinc
Copy link

Component(s)

exporter/azuremonitor

What happened?

Hello !
When I read the documentation about azuremonitor, it states that to compute response code for appInsight it took http.response_status or status_code.
Or Latest Semantic convention says that field that contains http status is http.response.status_code should be used so the mapping is really weird in our system.

Collector version

latest

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@aygalinc aygalinc added bug Something isn't working needs triage New item requiring triage labels Feb 14, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@aygalinc aygalinc changed the title [azuremonitorexporter] [azuremonitorexporter] Seems to not respect semantic convention Feb 14, 2024
@aygalinc aygalinc changed the title [azuremonitorexporter] Seems to not respect semantic convention [azuremonitorexporter] Seems to not respect semantic convention on http field for mapping Feb 14, 2024
@JorTurFer
Copy link

We are affected too by this

@aygalinc
Copy link
Author

@pcwiese :
Maybe i 'm wrong because i clearly have no experience in Go, i just download vscode for this and browse project and dependencies but for me it seems that the library that is genrated upon the semantic convention specification is not aligned with the latest version of the spec: https://pkg.go.dev/go.opentelemetry.io/collector/semconv@v0.94.1/v1.6.1 .

It clearly not integrate all breaking change on http introduce in version 1.21.0 dure to alignement with ECS naming.

@aygalinc
Copy link
Author

Seems the same for all other exporter if they rely on the same package no ?

@JorTurFer
Copy link

The problem is that v1.21 doesn't contain the new value either: https://pkg.go.dev/go.opentelemetry.io/collector/semconv@v0.94.1/v1.21.0 despite it's documented in the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/schemas/1.21.0

@aygalinc
Copy link
Author

Yep i check all the version and for me the code generation seems broken. But as i said i m not a go expert so i do not know if i look the right set of package module.
And i m also surprised that the module end at version 1.22.0 because they have release 2 news versions of the semantic spec

@aygalinc
Copy link
Author

aygalinc commented Feb 28, 2024

Yep the root cause is the same

@crobert-1
Copy link
Member

I'm going to close in favor of #29687, but let me know if this should remain open.

@crobert-1 crobert-1 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/azuremonitor needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

3 participants