Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/logstransform]: Long running tasks uses the wrong context #31140

Open
BinaryFissionGames opened this issue Feb 8, 2024 · 2 comments
Labels
bug Something isn't working never stale Issues marked with this label will be never staled and automatically removed processor/logstransform Logs Transform processor

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

processor/logstransform

Describe the issue you're reporting

The context passed in from Start should not be used for long-running operations; See the comment from the upstream collector:

// If the component needs to perform a long-running starting operation then it is recommended
// that Start() returns quickly and the long-running operation is performed in background.
// In that case make sure that the long-running operation does not use the context passed
// to Start() function since that context will be cancelled soon and can abort the long-running
// operation. Create a new context from the context.Background() for long-running operations.

https://github.com/open-telemetry/opentelemetry-collector/blob/9553bfeb936232fec9ff805ab763142880b391b6/component/component.go#L39-L44

This doesn't seem to actually lead to any negative effects, but it does seem that the logstransformprocessor is using the context passed in from start for long-running goroutines.

@BinaryFissionGames BinaryFissionGames added the needs triage New item requiring triage label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the processor/logstransform Logs Transform processor label Feb 8, 2024
@crobert-1 crobert-1 added the bug Something isn't working label Feb 9, 2024
@djaglowski djaglowski removed the needs triage New item requiring triage label Feb 12, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 15, 2024
@djaglowski djaglowski added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale Issues marked with this label will be never staled and automatically removed processor/logstransform Logs Transform processor
Projects
None yet
Development

No branches or pull requests

3 participants