-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http semantic convention breaking changes in 1.23 #30935
Comments
Thanks so much for the quick PR to address this :) Can I ask roughly when the fix will be released in a new version? |
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `awsxrayexporter` is able to handle both old and new versions of http span attributes, support translate new http attributes to xray segment fields by following http [server span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server) and [client span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-client) spec. **Link to tracking Issue:** <Issue number if applicable> #30935 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> https://opentelemetry.io/blog/2023/http-conventions-declared-stable/ --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
…elemetry#31120) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `awsxrayexporter` is able to handle both old and new versions of http span attributes, support translate new http attributes to xray segment fields by following http [server span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server) and [client span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-client) spec. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30935 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> https://opentelemetry.io/blog/2023/http-conventions-declared-stable/ --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
No response
What happened?
Description
http semantic convention 1.23.0 is declared as stable and introduces some attribute changes. For example,
AttributeHTTPMethod
is from http.method to http.request.method. Now most of language SDKs have moved to the latest http semantic convention and removed support environment variableOTEL_SEMCONV_STABILITY_OPT_IN
.Right now some vendors' exporter in Collector have translation logic like
If we cannot control what version of OTel SDK user is using, how does Collector ensure both forward and backward compatibility?
Steps to Reproduce
Expected Result
OTel Collector can handle both old and new version of SDK.
Actual Result
Collector version
0.93.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: