Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetricsreceiver] Deprecate the processesscraper #30895

Open
braydonk opened this issue Jan 30, 2024 · 8 comments
Open

[receiver/hostmetricsreceiver] Deprecate the processesscraper #30895

braydonk opened this issue Jan 30, 2024 · 8 comments
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed receiver/hostmetrics

Comments

@braydonk
Copy link
Contributor

braydonk commented Jan 30, 2024

Component(s)

[receiver/hostmetrics]

Is your feature request related to a problem? Please describe.

In the orbit of the coming semantic conventions changes, it was decided that the processesscraper should be deprecated in favour of adding the system.processes.* metrics to the processscraper directly.

Describe the solution you'd like

Instead of:

hostmetrics:
  scrapers:
    process:
    processes:

I would like the following config to give the same results:

hostmetrics:
  scrapers:
    process:
      metrics:
        system.processes.created:
          enabled: true
        system.processes.count:
          enabled: true

Describe alternatives you've considered

It might be useful to have particular flags on the processscraper to enable/disable per process metrics and enable/disable aggregate process metrics. This is because if you only want the system.processes.* metrics, it is quite tedious to manually disable all the other metrics through the configuration.

Additional context

This has two benefits:

  1. While the change hasn't formulated yet, there is a plan for the system.processes namespace to be renamed to conform with the semantic conventions rules around pluralized namespaces
  2. Collecting all the processes on the system only one time should be a performance/memory improvement.
@braydonk braydonk added enhancement New feature or request needs triage New item requiring triage labels Jan 30, 2024
@braydonk
Copy link
Contributor Author

I messed up submitting the issue and missed setting the component properly my bad

Copy link
Contributor

Pinging code owners for receiver/hostmetrics: @dmitryax @braydonk. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Out of ignorance, do you have a reference for where this was discussed and the decision was reached? This may need a deprecation warning and some time to pass before actually doing the work of deprecating it since the host metrics receiver is in beta.

@braydonk
Copy link
Contributor Author

braydonk commented Jan 31, 2024

It was discussed in System Semantic Conventions Meetings and directly between @dmitryax and I, so I don't have anything to link to. I should have opened the issue sooner, and my PR shouldn't gun it straight for deprecation. I admit I'm not fully familiar with the process for deprecation, where is that written down? I'll regroup and make sure I actually follow that here.

@crobert-1
Copy link
Member

No worries, just wanted to make sure I understood the context here. Thanks for adding more information!

For deprecation the closest thing would probably be here. This is for an entire component, but I think the idea is generally applicable to this situation.

Your initial PR isn't actually removing things, so I think it's probably still matching expectations here.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 31, 2024
@ChrsMark
Copy link
Member

ChrsMark commented Feb 8, 2024

It was discussed in System Semantic Conventions Meetings and directly between @dmitryax and I, so I don't have anything to link to.

That was also summarised at open-telemetry/semantic-conventions#484 (comment).

While the change hasn't formulated yet, there is a plan for the system.processes namespace to be renamed to conform with the semantic conventions rules around pluralized namespaces

The change in the SemConv has also already been merged: open-telemetry/semantic-conventions#484

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 9, 2024
@crobert-1 crobert-1 removed the Stale label Apr 9, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 10, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed receiver/hostmetrics
Projects
None yet
Development

No branches or pull requests

3 participants