Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awscloudwatchlogs] placeholders support for log_group_name and log_stream_name #30773

Open
prashant-shahi opened this issue Jan 25, 2024 · 12 comments
Labels
discussion needed Community discussion needed enhancement New feature or request exporter/awscloudwatchlogs awscloudwatchlogs exporter

Comments

@prashant-shahi
Copy link
Contributor

prashant-shahi commented Jan 25, 2024

Component(s)

exporter/awscloudwatchlogs

Is your feature request related to a problem? Please describe.

Yes.

Currently, all incoming log data are written to a single log group/stream by the exporter. Making it difficult to filter them in AWS Cloudwatch.

Describe the solution you'd like

Support for placeholders like:

  • {ClusterName}
  • {TaskId}
  • {NodeName}
  • {ContainerInstanceId}
  • {TaskDefinitionFamily}

Similar to the format supported by awsemfexporter. With the values supported from OpenTelemetry ECS-like attributes.

Describe alternatives you've considered

No response

Additional context

No response

/cc @boostchicken, @bryan-aguilar, @rapphil

@prashant-shahi prashant-shahi added enhancement New feature or request needs triage New item requiring triage labels Jan 25, 2024
@prashant-shahi prashant-shahi changed the title placeholders support for log_group_name and log_stream_name [exporter/awscloudwatchlogs] placeholders support for log_group_name and log_stream_name Jan 25, 2024
@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Jan 25, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@bryan-aguilar
Copy link
Contributor

I've thought about this in the past but don't have anything written down quite yet. I think there are a few different options to go with and I would seek something a bit more permissive than the original suggestion. I think one of the thoughts that I have had in the past is that the exporter could look for a specific resource attribute, if present use that. It gives more options for where that resource attributes is populated.

@bryan-aguilar bryan-aguilar added discussion needed Community discussion needed and removed needs triage New item requiring triage labels Feb 3, 2024
@sbarhouche
Copy link

@bryan-aguilar it could be similar to the approach followed by fluentbit for aws
image

@koenvandesande
Copy link

Being able to reference attributes from the log message itself for the logStreamName would be nice (to split it out again over containers/components). Or referencing something unique like the date or time that the collector started.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 29, 2024
@sbarhouche
Copy link

@bryan-aguilar any workaround for this ?

@github-actions github-actions bot removed the Stale label May 29, 2024
@bpalermo
Copy link

For simple use cases, at the very least we could start with support for templating based on attributes for the log stream name, since it's possible to use routingprocessor to route to different log groups. Although this is not ideal since would mean multiple exporters.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 30, 2024
@using-system
Copy link

Same here !
We needs for this features because we want to have on collector for mulitple app and each app has his own log group name !

any update ?

@github-actions github-actions bot removed the Stale label Aug 8, 2024
@eOkadas
Copy link

eOkadas commented Aug 8, 2024

It would seem this use case of sharing a collector and having it dispatch to different log groups is a widespread need. We have the same issue.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 8, 2024
@sbarhouche
Copy link

Pinging code owners:

exporter/awscloudwatchlogs: @boostchicken @bryan-aguilar @rapphil

@github-actions github-actions bot removed the Stale label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed Community discussion needed enhancement New feature or request exporter/awscloudwatchlogs awscloudwatchlogs exporter
Projects
None yet
Development

No branches or pull requests

7 participants