Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Support KSM-equivalent custom resource state metrics #30655

Closed
rtrevi opened this issue Jan 17, 2024 · 4 comments
Closed

Comments

@rtrevi
Copy link

rtrevi commented Jan 17, 2024

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

I'm setting up alerts for fluxcd based on prometheus metrics.

Newer versions of Flux drop some of the exposed metrics in favour of kube-state-metrics custom resource state: https://fluxcd.io/flux/monitoring/metrics/#warning-deprecated-resource-metrics

Afaik, there's no existing feature in the k8sclusterreceiver (or in any receiver/processor for that matter) that accomplishes the same as KSM's custom metrics: https://github.com/kubernetes/kube-state-metrics/blob/main/docs/customresourcestate-metrics.md

Describe the solution you'd like

Support defining custom metrics from custom resources status.

Describe alternatives you've considered

No response

Additional context

No response

@rtrevi rtrevi added enhancement New feature or request needs triage New item requiring triage labels Jan 17, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rtrevi rtrevi changed the title Support custom resource state metrics [receiver/k8sclusterreceiver] Support custom resource state metrics Jan 17, 2024
@rtrevi rtrevi changed the title [receiver/k8sclusterreceiver] Support custom resource state metrics [receiver/k8sclusterreceiver] Support KSM-equivalent custom resource state metrics Jan 17, 2024
@rtrevi rtrevi changed the title [receiver/k8sclusterreceiver] Support KSM-equivalent custom resource state metrics [receiver/k8scluster] Support KSM-equivalent custom resource state metrics Jan 17, 2024
@povilasv
Copy link
Contributor

povilasv commented Jan 18, 2024

The feature is pretty cool and makes sense. But it might be a bit difficult to do. We would need to decide on the syntax of going thru CRDs like (https://github.com/kubernetes/kube-state-metrics/blob/main/docs/customresourcestate-metrics.md#path-syntax) then figure out how to allow users to map the to resource attributes, attributes, one of the value types or units.

Maybe somhow using OTTL here would be possible 🤔

Would be cool to get some kind of proposal / design of the config first.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 19, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants