-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Deprecate mode: ecs
configuration option and change default to mode: none
#30441
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@JaredTan95 is this change the future plan for the component? I had previously submitted #30454 but wasn't able to follow up before it got closed as stale. I can reopen the PR if there is interest in that alternate direction. |
@j-kap-t Sorry for the late reply, I think you can reopen your PR and push forward it~ @ycombinator FYI, #30454 implements |
Thanks @JaredTan95 , I had to recreate it since I don't have permissions to re-open: #31553. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/elasticsearch
Describe the issue you're reporting
Summarizing relevant bits from this conversation:
The
elasticsearch
exporter supports amode
configuration option. The default value of this option isecs
. Other supported values arenone
and, after #29619 is merged,raw
.Looking at the exporter's code, it appears that the
mode: ecs
configuration doesn't have any effect and is functionally the same asmode: none
. So the proposal is to deprecatemode: ecs
and makemode: none
the default instead. After a sufficient amount of deprecation time — 3 months? 6 months? — removemode: ecs
altogether.The text was updated successfully, but these errors were encountered: