Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Deprecate mode: ecs configuration option and change default to mode: none #30441

Closed
ycombinator opened this issue Jan 11, 2024 · 6 comments

Comments

@ycombinator
Copy link
Contributor

Component(s)

exporter/elasticsearch

Describe the issue you're reporting

Summarizing relevant bits from this conversation:

The elasticsearch exporter supports a mode configuration option. The default value of this option is ecs. Other supported values are none and, after #29619 is merged, raw.

Looking at the exporter's code, it appears that the mode: ecs configuration doesn't have any effect and is functionally the same as mode: none. So the proposal is to deprecate mode: ecs and make mode: none the default instead. After a sufficient amount of deprecation time — 3 months? 6 months? — remove mode: ecs altogether.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@j-kap-t
Copy link
Contributor

j-kap-t commented Feb 26, 2024

@JaredTan95 is this change the future plan for the component? I had previously submitted #30454 but wasn't able to follow up before it got closed as stale. I can reopen the PR if there is interest in that alternate direction.

@JaredTan95
Copy link
Member

JaredTan95 commented Mar 4, 2024

@JaredTan95 is this change the future plan for the component? I had previously submitted #30454 but wasn't able to follow up before it got closed as stale. I can reopen the PR if there is interest in that alternate direction.

@j-kap-t Sorry for the late reply, I think you can reopen your PR and push forward it~

@ycombinator FYI, #30454 implements ecs mode and sets the default mode to none

@j-kap-t
Copy link
Contributor

j-kap-t commented Mar 4, 2024

Thanks @JaredTan95 , I had to recreate it since I don't have permissions to re-open: #31553.

Copy link
Contributor

github-actions bot commented May 6, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 6, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants