Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility metric type summary #30156

Closed
maokitty opened this issue Dec 21, 2023 · 7 comments
Closed

Compatibility metric type summary #30156

maokitty opened this issue Dec 21, 2023 · 7 comments
Labels
closed as inactive processor/cumulativetodelta Cumulative To Delta processor processor/transform Transform processor question Further information is requested Stale

Comments

@maokitty
Copy link

Component(s)

processor/cumulativetodelta

Is your feature request related to a problem? Please describe.

As there is a summary in prometheus and opentelemetry-summary-legacy, convert it to delta for compatibility.

Describe the solution you'd like

Convert sum and count to delta and leave quantiles unchanged as quantile are time window based values.

Describe alternatives you've considered

No response

Additional context

No response

@maokitty maokitty added enhancement New feature or request needs triage New item requiring triage labels Dec 21, 2023
@github-actions github-actions bot added the processor/cumulativetodelta Cumulative To Delta processor label Dec 21, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi
Copy link
Member

mx-psi commented Dec 21, 2023

@maokitty A summary does not have an aggregation temporality field https://github.com/open-telemetry/opentelemetry-proto/blob/ea449ae0e9b282f96ec12a09e796dbb3d390ed4f/opentelemetry/proto/metrics/v1/metrics.proto#L245-L247 as opposed to all other metric types handled by the cumulative to delta processor.

I think a solution here would be for something like the transform processor to allow you to split a summary into its constituent parts (count, sum, quantiles as separate metrics) and then apply cumulative-to-delta to them.

@crobert-1 crobert-1 added question Further information is requested processor/transform Transform processor and removed enhancement New feature or request needs triage New item requiring triage labels Dec 21, 2023
Copy link
Contributor

Pinging code owners for processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi
Copy link
Member

mx-psi commented Jan 8, 2024

I think they should be, maybe a quantiles one would be helpful as well but IMO we should wait until someone explicitly asks for it

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 11, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive processor/cumulativetodelta Cumulative To Delta processor processor/transform Transform processor question Further information is requested Stale
Projects
None yet
Development

No branches or pull requests

4 participants