Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Attrs + Operation based routing in loadbalancing exporter for traces #30146

Closed
aishyandapalli opened this issue Dec 20, 2023 · 4 comments
Labels
enhancement New feature or request exporter/loadbalancing needs triage New item requiring triage Stale

Comments

@aishyandapalli
Copy link
Contributor

aishyandapalli commented Dec 20, 2023

Component(s)

exporter/loadbalancing

Is your feature request related to a problem? Please describe.

Right now, we have traceID and service based routing for traces in loadbalancing exporter. We see the traffic is unbalanced for both the routing types. We want to add a new entry for resource attributes+operation combination to balance the traffic across backends.

Describe the solution you'd like

Add a new entry key for resource attributes+operation routing and route the traffic based on the ids computed with resource attributes+operation combination

Describe alternatives you've considered

No response

Additional context

No response

@aishyandapalli aishyandapalli added enhancement New feature or request needs triage New item requiring triage labels Dec 20, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@aishyandapalli aishyandapalli changed the title Add Service + Operation based routing in loadbalancing exporter for traces Add Service + TraceID based routing in loadbalancing exporter for traces Dec 21, 2023
@aishyandapalli aishyandapalli changed the title Add Service + TraceID based routing in loadbalancing exporter for traces Add Service + Operation based routing in loadbalancing exporter for traces Dec 22, 2023
@aishyandapalli aishyandapalli changed the title Add Service + Operation based routing in loadbalancing exporter for traces Resource Attrs + Operation based routing in loadbalancing exporter for traces Dec 22, 2023
@jpkrohling
Copy link
Member

We see the traffic is unbalanced for both the routing types

That's surprising: balancing via trace ID should be relatively acceptable. I'd be curious to see the load-balancer metrics for that. Would you be able to share them?

We want to add a new entry for resource attributes+operation combination to balance the traffic across backends.

Do you mind sharing more details about this? Which concrete values would you be using to improve the balancing? "Operation" (span name, I assume) cannot be used for the load balancing, as it would result in spans from the same trace reaching different backends.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

I'm closing, but if you have answers to the questions above, please comment and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/loadbalancing needs triage New item requiring triage Stale
Projects
None yet
Development

No branches or pull requests

2 participants