Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring Kafka client Client ID in kafka exporter #30144

Closed
richardartoul opened this issue Dec 20, 2023 · 2 comments
Closed

Support configuring Kafka client Client ID in kafka exporter #30144

richardartoul opened this issue Dec 20, 2023 · 2 comments
Labels
enhancement New feature or request exporter/kafka

Comments

@richardartoul
Copy link
Contributor

Component(s)

exporter/kafka

Is your feature request related to a problem? Please describe.

Kafka client IDs are an important part of the ecosystem / protocol and have a variety of benefits:

  1. They can be used for throttling and quota enforcements of different producers / consumers in a shared multi-tenant Kafka cluster.
  2. They can be used for observability in terms of producing, consumer, and consumer group behavior.
  3. Some Apache Kafka protocol compatible systems like WarpStream leverage them to route clients to nodes running in the same availability zone to avoid inter-zone networking costs which can be quite high when exporting logs/traces.

Describe the solution you'd like

It would be great if users could provide the kafka client ID to use in the Sarama client as part of their configuration.

Describe alternatives you've considered

I can't think of any viable alternatives other than letting people specify the client ID explicitly in the configuration file.

Additional context

No response

@richardartoul richardartoul added enhancement New feature or request needs triage New item requiring triage labels Dec 20, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@richardartoul
Copy link
Contributor Author

This P.R should do it: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30145/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/kafka
Projects
None yet
Development

No branches or pull requests

3 participants