Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support http (security) headers in opamp supervisor #30137

Closed
cforce opened this issue Dec 20, 2023 · 9 comments
Closed

support http (security) headers in opamp supervisor #30137

cforce opened this issue Dec 20, 2023 · 9 comments
Labels

Comments

@cforce
Copy link

cforce commented Dec 20, 2023

Component(s)

No response

Is your feature request related to a problem? Please describe.

Please add support for standard and custom security headers in opamp supervisor configuration.

Describe the solution you'd like

server:
  endpoint: wss://localhost:4320/v1/opamp
  headers:
    Authorization: key value
    x: 123445
    y:  hello
         

Especially it would be beneficial if authorization based on opneid connect is supported like its done fpr exporters by otel collector via extension https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/8f6fc8f16a628e0c4d6bdfd4f516ddb46b899e0c/extension/oidcauthextension

extensions:
  oidc:
    issuer_url: http://localhost:8080/auth/realms/opentelemetry
    issuer_ca_path: /etc/pki/tls/cert.pem
    audience: account
    username_claim: email

server:
  endpoint: wss://localhost:4320/v1/opamp
  auth:
    authenticator: oidc

Describe alternatives you've considered

No response

Additional context

No response

@cforce cforce added enhancement New feature or request needs triage New item requiring triage labels Dec 20, 2023
Copy link
Contributor

Pinging code owners for cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Dec 25, 2023
@srikanthccv
Copy link
Member

Headers support will be added as a part of this PR #30237

Copy link
Contributor

github-actions bot commented Mar 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 1, 2024
@cforce
Copy link
Author

cforce commented Apr 16, 2024

@srikanthccv Can we close this?

@srikanthccv
Copy link
Member

Yes, the server config supports headers now.

@evan-bradley
Copy link
Contributor

Closing as resolved via #30237

@cforce
Copy link
Author

cforce commented Jun 17, 2024

@srikanthccv @evan-bradley
This issue was rquesting as well support for openid

As far as i understood only below is now supported

server:
  endpoint: wss://localhost:4320/v1/opamp
  headers:
    Authorization: key value
    x: 123445
    y:  hello

but still below openid is not, is it?

extensions:
  oidc:
    issuer_url: http://localhost:8080/auth/realms/opentelemetry
    issuer_ca_path: /etc/pki/tls/cert.pem
    audience: account
    username_claim: email

server:
  endpoint: wss://localhost:4320/v1/opamp
  auth:
    authenticator: oidc

Can we reopen or do you want me to create an additional request?

@srikanthccv
Copy link
Member

Please create a separate issue because the supporting auth extension is independent work.

@cforce
Copy link
Author

cforce commented Jun 17, 2024

Ok . see #33590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants