Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azuremonitor] do not skip lifecycle tests #30038

Closed
codeboten opened this issue Dec 18, 2023 · 4 comments
Closed

[receiver/azuremonitor] do not skip lifecycle tests #30038

codeboten opened this issue Dec 18, 2023 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed receiver/azuremonitor

Comments

@codeboten
Copy link
Contributor 

          add issue to not skip lifecycle tests

Originally posted by @codeboten in #30024 (comment)
@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/azuremonitor: @altuner @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Dec 19, 2023
Closed
@cheskayang cheskayang mentioned this issue Dec 24, 2023
Merged
codeboten pushed a commit that referenced this issue Dec 28, 2023
@cheskayang
[receiver/azuremonitor] do not skip lifecycle tests (#30198)
fbae4bb 
hello this is my first PR :)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
- remove the skip_lifecycle flag
- regenerate tests
- fix failing tests

**Link to tracking Issue:** <Issue number if applicable>

#30038

**Testing:** <Describe what testing was performed and which tests were
added.>
existing tests

**Documentation:** <Describe the documentation added.>
no change
@ChrsMark
Copy link
Member

ChrsMark commented Jan 8, 2024

This one should be fixed by #30198.

cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@cheskayang @cparkins
[receiver/azuremonitor] do not skip lifecycle tests (open-telemetry#3…
f011dc0 
…0198)

hello this is my first PR :)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
- remove the skip_lifecycle flag
- regenerate tests
- fix failing tests

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#30038

**Testing:** <Describe what testing was performed and which tests were
added.>
existing tests

**Documentation:** <Describe the documentation added.>
no change
@nslaughter
Copy link
Contributor

nslaughter commented Feb 14, 2024 •
edited
Loading

I believe this issue should be closed.
The issue is that lifecycle tests were skipped. And #30198 removed the skip_lifecycle flag.

@codeboten
Copy link
Contributor Author

Thanks @ChrsMark @nslaughter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed receiver/azuremonitor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codeboten @songy23 @ChrsMark @nslaughter