Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog: Support logging of full metrics payloads #29701

Open
ringerc opened this issue Dec 8, 2023 · 4 comments
Open

datadog: Support logging of full metrics payloads #29701

ringerc opened this issue Dec 8, 2023 · 4 comments
Labels
data:metrics Metric related issues enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@ringerc
Copy link

ringerc commented Dec 8, 2023

Component(s)

exporter/datadog

Is your feature request related to a problem? Please describe.

The datadog exporter has the logs.dump_payloads configuration option, but it does not appear to have any similar one for metrics (or traces).

The datadog exporter does its own internal munging of metrics, transforming resource attributes to various datadog tags, etc. This is affected by lightly documented config options like resource_attributes_as_tags, but it can be hard to tell what exactly the DD exporter is doing to the metrics before delivery.

Since the DD ingestion pipeline also has various configuration for tag remapping (some of it present by default) it can be hard to tell where tags like "cloud_provider" or "zone" come from. They don't appear in the "debug" exporter stream when set to log the detailed payloads, so they're being added by Datadog either on the collector or on the backend... but where, why, and how?

Describe the solution you'd like

A metrics.dump_payloads (and traces.dump_payloads) option to log the full payloads as they will be sent to the Datadog API endpoint.

Describe alternatives you've considered

Enabling debug log level for the exporter as a whole does not appear to cause the datadog exporter to log payload details. Which is fine, that's probably not desirable, but it'd be good to have some way to do this.

Additional context

See #29702 for added confusion the apparently-ignored metrics.resource_attributes_as_tags option introduces, and the undocumented mapping of OpenTelemetry semantic conventions resource attributes the Datadog exporter does to datadog tags.

@ringerc ringerc added enhancement New feature or request needs triage New item requiring triage labels Dec 8, 2023
@github-actions github-actions bot added the exporter/datadog Datadog components label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ringerc ringerc changed the title datadog: Suppot logging of full metrics payloads datadog: Support logging of full metrics payloads Dec 8, 2023
@ringerc
Copy link
Author

ringerc commented Dec 11, 2023

This would've made it way easier to figure out the behaviour in #29702 for example.

It's especially important since the Datadog platform offers no way to see the "raw" feed of incoming metrics with each datum's tags etc. You can only see the summary, which combines all recent tags from all sources. Fiddly queries are required to figure out what's actually being sent currently by any given source.

@mackjmr
Copy link
Member

mackjmr commented Dec 12, 2023

Hi @ringerc, I've created a task in our backlog to add support for dump_payloads for traces/metrics. For tracking purposes, can you please open a support ticket referencing this issue ?

@songy23 songy23 added waiting for author and removed needs triage New item requiring triage labels Dec 12, 2023
@ringerc
Copy link
Author

ringerc commented Jan 4, 2024

@mackjmr Done, DD support ticket 1486970

@songy23 songy23 added priority:p2 Medium never stale Issues marked with this label will be never staled and automatically removed and removed waiting for author labels Jan 4, 2024
@mx-psi mx-psi added the data:metrics Metric related issues label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:metrics Metric related issues enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

4 participants