Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/honeycombmarker] Use the service.name resource attribute to set dataset_slug #29407

Open
TylerHelmuth opened this issue Nov 20, 2023 · 4 comments
Labels
enhancement New feature or request exporter/honeycombmarker never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@TylerHelmuth
Copy link
Member

Component(s)

No response

Is your feature request related to a problem? Please describe.

Currently the honeycombmarker exporter allows you to specify exactly 1 dataset per marker. If you want to create a marker in different datasets based on similar conditions you have to keep recreating the marker.

Describe the solution you'd like

Allow the exporter to use service.name resource attribute to determine the dataset. With that feature in place a user could create a rule like to following:

exporters:
  honeycombmarker:
    api_key: {{env:HONEYCOMB_API_KEY}}
    markers:
      - type: k8s-backoff-events
        useServiceName: true 
        rules:
          - log_conditions:
              - IsMap(body) and IsMap(body["object"]) and body["object"]["reason"] == "Backoff"

That rule could then create markers in specific datasets based on the service that produced the log. Without this feature, you'd have to do

exporters:
  honeycombmarker:
    api_key: {{env:HONEYCOMB_API_KEY}}
    markers:
      - type: k8s-backoff-events
        dataset_slug: "foo" 
        rules:
          - log_conditions:
              - IsMap(body) and IsMap(body["object"]) and body["object"]["reason"] == "Backoff" and resource.attributes["service.name"] == "foo"
      - type: k8s-backoff-events
        dataset_slug: "bar" 
        rules:
          - log_conditions:
              - IsMap(body) and IsMap(body["object"]) and body["object"]["reason"] == "Backoff" and resource.attributes["service.name"] == "bar"

Describe alternatives you've considered

No response

Additional context

We need to think about how this config option interacts with dataset_slug? If both are set, which takes precedence? Should only 1 be settable at a time?

@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage exporter/honeycombmarker priority:p2 Medium and removed needs triage New item requiring triage labels Nov 20, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 29, 2024
@TylerHelmuth TylerHelmuth added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/honeycombmarker never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

1 participant