Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/opamp] The effective configuration is not what is expected #29117

Closed
brightzheng100 opened this issue Nov 12, 2023 · 3 comments
Closed
Labels
bug Something isn't working extension/opamp

Comments

@brightzheng100
Copy link

Component(s)

extension/opamp

What happened?

Description

When extension/opamp is enabled, the effective configuration viewed in the UI, should be exactly the actual configuration plus merged extra configuration by the extension itself.

But as of now, it's not the case.

Steps to Reproduce

  1. Spin up the OpAMP server:
git clone https://github.com/open-telemetry/opamp-go.git
make build-example-server
cd internal/examples/server
./bin/server

Then I can access the UI at: http://127.0.0.1:4321/

  1. Customize the Otel Collector:

Open another console.

cat <<EOF > builder-config.yaml
dist:
  name: otelcol-dev
  description: Basic OTel Collector distribution for Developers
  output_path: ./otelcol-dev
  otelcol_version: 0.88.0

exporters:
  - gomod:
      # debug
      go.opentelemetry.io/collector/exporter/debugexporter v0.88.0
  - gomod:
      # otlp
      go.opentelemetry.io/collector/exporter/otlpexporter v0.88.0

receivers:
  - gomod:
      # otlp
      go.opentelemetry.io/collector/receiver/otlpreceiver v0.88.0

processors:
  - gomod:
      # batch
      go.opentelemetry.io/collector/processor/batchprocessor v0.88.0

extensions:
  - gomod:
      # opamp
      github.com/open-telemetry/opentelemetry-collector-contrib/extension/opampextension 22d86de838858c25d1d644b84221eb37198d2c86
EOF

./ocb --config builder-config.yaml
  1. Configure the Collector and start it up:
receivers:
  otlp:
    protocols:
      grpc:

exporters:
  debug:
    verbosity: detailed

extensions:
  opamp:
    server:
      ws:
        endpoint: wss://127.0.0.1:4320/v1/opamp
        tls:
          insecure_skip_verify: true
    #instance_uid: 01ARZ3NDEKTSV4RRFFQ69G5FAV

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [debug]
  telemetry:
    logs:
      level: debug
  extensions: [opamp]
  1. Check out the UI:

What I saw in the Effective Configuration is as below, which is NOT the right effective configuration:

exporters:
  otlp:
    endpoint: localhost:1111
receivers:
  otlp:
    protocols:
      grpc: {}
      http: {}
service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: []
      exporters: [otlp]
image

Expected Result

The effective configuration should be the actual configuration plus potentially merged extra configuration by the extension itself.

Actual Result

Some components, say debug exporters, telemetry service are missing.

Collector version

22d86de

Environment information

Environment

OS: MBP with M1 chip
Compiler(if manually compiled): go version go1.21.3 darwin/arm64

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@brightzheng100 brightzheng100 added bug Something isn't working needs triage New item requiring triage labels Nov 12, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95
Copy link
Member

JaredTan95 commented Nov 14, 2023

@brightzheng100 Hi, it's not a bug, It's a not fully complete feature and is still in development. refs: #27293

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Nov 14, 2023
@haoqixu
Copy link
Member

haoqixu commented Dec 8, 2023

completed in #29277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension/opamp
Projects
None yet
Development

No branches or pull requests

3 participants