Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/signalfx] Flaky test - TestTLSAPIConnection/API_CA_set #29099

Closed
djaglowski opened this issue Nov 10, 2023 · 5 comments · Fixed by #29109
Closed

[exporter/signalfx] Flaky test - TestTLSAPIConnection/API_CA_set #29099

djaglowski opened this issue Nov 10, 2023 · 5 comments · Fixed by #29109
Assignees
@crobert-1
Labels
exporter/signalfx

Comments

@djaglowski
Copy link
Member

Component(s)

exporter/signalfx

Describe the issue you're reporting

...
2023/11/10 14:49:56 http: TLS handshake error from 127.0.0.1:41532: remote error: tls: bad certificate
2023/11/10 14:49:56 http: TLS handshake error from 127.0.0.1:41536: remote error: tls: bad certificate
2023/11/10 14:49:56 http: TLS handshake error from 127.0.0.1:41540: remote error: tls: bad certificate
2023/11/10 14:49:56 http: TLS handshake error from 127.0.0.1:41554: read tcp 127.0.0.1:44933->127.0.0.1:41554: use of closed network connection
--- FAIL: TestTLSAPIConnection (6.01s)
    --- FAIL: TestTLSAPIConnection/API_CA_set (3.00s)
        exporter_test.go:1423: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/signalfxexporter/exporter_test.go:1423
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 237
            	Test:       	TestTLSAPIConnection/API_CA_set
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	coverage: 88.4% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	8.658s

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6826190633/job/18565600283#step:9:991
@djaglowski djaglowski added the needs triage New item requiring triage label Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 mentioned this issue Nov 10, 2023
Merged
songy23 added a commit to songy23/opentelemetry-service-contrib that referenced this issue Nov 10, 2023
@songy23
open-telemetry#29099 skip flaky test for now
f846797
songy23 added a commit that referenced this issue Nov 10, 2023
@songy23
#29099 skip flaky test for now (#29103)
b0353a2
@crobert-1
Copy link
Member 

2023/11/10 18:04:47 http: TLS handshake error from 127.0.0.1:33918: remote error: tls: bad certificate
2023/11/10 18:04:47 http: TLS handshake error from 127.0.0.1:33932: write tcp 127.0.0.1:37857->127.0.0.1:33932: use of closed network connection
--- FAIL: TestTLSAPIConnection (6.02s)
    --- FAIL: TestTLSAPIConnection/API_CA_set (3.00s)
        exporter_test.go:1423: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/signalfxexporter/exporter_test.go:1423
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 240
            	Test:       	TestTLSAPIConnection/API_CA_set
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	coverage: 88.4% of statements

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6828055284/job/18571512872?pr=28649

@crobert-1 crobert-1 mentioned this issue Nov 10, 2023
Merged
@songy23
Copy link
Member

songy23 commented Nov 10, 2023

One more: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6827788467/job/18570645932?pr=29101#step:9:472

@sakulali
Copy link
Contributor

It seems opentelemetry-collector-contrib/exporter/signalfxexporter/testdata/certs/cert.pem has expired:

➜  certs git:(main) ✗ openssl x509 -enddate -noout -in ca.pem
notAfter=Nov  9 00:58:00 2027 GMT
➜  certs git:(main) ✗ openssl x509 -enddate -noout -in cert.pem
notAfter=Nov 10 01:01:00 2023 GMT

@crobert-1
Copy link
Member

crobert-1 commented Nov 10, 2023 •
edited
Loading

Thanks @sakulali, that looks to be the issue. For context, this was added in #16250.

@crobert-1 crobert-1 added flaky test a test is flaky and removed needs triage New item requiring triage labels Nov 10, 2023
@mrsillydog mrsillydog mentioned this issue Nov 10, 2023
Merged
crobert-1 added a commit to crobert-1/opentelemetry-collector-contrib that referenced this issue Nov 10, 2023
@crobert-1
[chore][exporter/signalfx] Update test certs
df191d8 
This re-enables the failing tests and updates the given certs

Fixes open-telemetry#29099
@crobert-1 crobert-1 mentioned this issue Nov 10, 2023
Merged
@crobert-1 crobert-1 self-assigned this Nov 10, 2023
@crobert-1 crobert-1 removed the flaky test a test is flaky label Nov 10, 2023
@github-actions github-actions bot mentioned this issue Nov 14, 2023
Closed
mx-psi pushed a commit that referenced this issue Nov 14, 2023
@crobert-1
[chore][exporter/signalfx] Update test certs (#29109)
7dc7f76 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This re-enables the failing tests and updates the expired certificates.

New cert expiration dates:
```
$ openssl x509 -enddate -noout -in testdata/certs/cert.pem 
notAfter=Mar 13 22:55:27 3023 GMT
$ openssl x509 -enddate -noout -in testdata/certs/ca.pem 
notAfter=Mar 13 22:47:43 3023 GMT
```
**Link to tracking Issue:** <Issue number if applicable>
Fixes #29099 

**Testing:** <Describe what testing was performed and which tests were
added.>
Tests are now passing.

**Documentation:** <Describe the documentation added.>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@crobert-1 @RoryCrispin
[chore][exporter/signalfx] Update test certs (open-telemetry#29109)
4907b3b 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This re-enables the failing tests and updates the expired certificates.

New cert expiration dates:
```
$ openssl x509 -enddate -noout -in testdata/certs/cert.pem 
notAfter=Mar 13 22:55:27 3023 GMT
$ openssl x509 -enddate -noout -in testdata/certs/ca.pem 
notAfter=Mar 13 22:47:43 3023 GMT
```
**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#29099 

**Testing:** <Describe what testing was performed and which tests were
added.>
Tests are now passing.

**Documentation:** <Describe the documentation added.>
drubinMeta pushed a commit to nsofnetworks/opentelemetry-collector-contrib that referenced this issue Dec 14, 2023
@crobert-1 @drubinMeta
Update test certs (open-telemetry#29109)
299e6e3 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This re-enables the failing tests and updates the expired certificates.

New cert expiration dates:
```
$ openssl x509 -enddate -noout -in testdata/certs/cert.pem
notAfter=Mar 13 22:55:27 3023 GMT
$ openssl x509 -enddate -noout -in testdata/certs/ca.pem
notAfter=Mar 13 22:47:43 3023 GMT
```
**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#29099

**Testing:** <Describe what testing was performed and which tests were
added.>
Tests are now passing.

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crobert-1 crobert-1

Labels
exporter/signalfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][exporter/signalfx] Update test certs crobert-1/opentelemetry-collector-contrib
4 participants
@sakulali @djaglowski @songy23 @crobert-1