Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] coreinternal/consumerretry/logs_test.go failed on windows #28694

Open
songy23 opened this issue Oct 30, 2023 · 8 comments
Open

[Flaky test] coreinternal/consumerretry/logs_test.go failed on windows #28694

songy23 opened this issue Oct 30, 2023 · 8 comments
Labels
flaky test a test is flaky good first issue Good for newcomers help wanted Extra attention is needed internal/core never stale Issues marked with this label will be never staled and automatically removed os:windows

Comments

@songy23
Copy link
Member

songy23 commented Oct 30, 2023

Component(s)

internal/core

What happened?

internal/coreinternal/consumerretry/logs_test.go is broken on Windows test matrix on mainline https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test-windows.yml?query=branch%3Amain

--- FAIL: TestConsumeLogs (0.12s)
    --- FAIL: TestConsumeLogs/retry_success (0.10s)
        logs_test.go:66: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/coreinternal/consumerretry/logs_test.go:66
            	Error:      	Not equal: 
            	            	expected: <nil>(<nil>)
            	            	actual  : *errors.errorString(&errors.errorString{s:"retry later"})
            	Test:       	TestConsumeLogs/retry_success
--- FAIL: TestConsumeLogs_ContextDeadline (0.07s)
    logs_test.go:92: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/coreinternal/consumerretry/logs_test.go:92
        	Error:      	"retry later" does not contain "context is cancelled or timed out retry later"
        	Test:       	TestConsumeLogs_ContextDeadline
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/consumerretry	0.569s

Collector version

mainline

Environment information

Environment

OS: Windows

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@songy23 songy23 added help wanted Extra attention is needed good first issue Good for newcomers flaky test a test is flaky os:windows needs triage New item requiring triage internal/core labels Oct 30, 2023
@github-actions
Copy link
Contributor

Pinging code owners for internal/core: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners:

  • internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@pjanotti
Copy link
Contributor

I tried multiple runs on my box and got no repro. However, by code inspection I can see, that due to some concurrency on the test code, how both errors could happen. In theory the fix can happen on any system not only Windows. The fix should be entirely on the test code. Giving that this one seems hard to repro I'm giving it a low priority on my work queue, if some volunteer wants to fix them, please do so.

@crobert-1
Copy link
Member

Removing needs triage based on @pjanotti's comment.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 31, 2023
@pjanotti
Copy link
Contributor

pjanotti commented Nov 7, 2023

Hit the first one on my fork - documenting here to give a sense of frequency so we can prioritize them accordingly

https://github.com/pjanotti/opentelemetry-service-contrib/actions/runs/6789094249/job/18455541281#:~:text=%2D%2D%2D%20FAIL%3A%20TestConsumeLogs%20(0.12s,588

--- FAIL: TestConsumeLogs (0.12s)
    --- FAIL: TestConsumeLogs/retry_success (0.11s)
        logs_test.go:66: 
            	Error Trace:	D:/a/opentelemetry-service-contrib/opentelemetry-service-contrib/internal/coreinternal/consumerretry/logs_test.go:66
            	Error:      	Not equal: 
            	            	expected: <nil>(<nil>)
            	            	actual  : *errors.errorString(&errors.errorString{s:"retry later"})
            	Test:       	TestConsumeLogs/retry_success
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/consumerretry	0.251s

Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 8, 2024
@songy23 songy23 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jan 8, 2024
@pjanotti
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test a test is flaky good first issue Good for newcomers help wanted Extra attention is needed internal/core never stale Issues marked with this label will be never staled and automatically removed os:windows
Projects
None yet
Development

No branches or pull requests

3 participants