Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/aws] Flaky test TestSweep on Windows #27892

Closed
pjanotti opened this issue Oct 20, 2023 · 5 comments
Closed

[internal/aws] Flaky test TestSweep on Windows #27892

pjanotti opened this issue Oct 20, 2023 · 5 comments

Comments

@pjanotti
Copy link
Contributor

Component(s)

internal/aws

Describe the issue you're reporting

Test failure on unrelated change https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6588556890/job/17901091034?pr=27864#step:6:503

make[2]: Entering directory 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/aws/metrics'
go test -race -timeout 300s -parallel 4 --tags="" ./...
--- FAIL: TestSweep (0.24s)
    metric_calculator_test.go:276: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/aws/metrics/metric_calculator_test.go:276
        	Error:      	"2.2815ms" is not less than or equal to "1ms"
        	Test:       	TestSweep
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/metrics	0.591s
FAIL
@pjanotti pjanotti added the needs triage New item requiring triage label Oct 20, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@bryan-aguilar
Copy link
Contributor

This is a side effect of the test requiring an action to be done within a certain time frame which can be dependent on many factors. We could take a look at the test case again to see if bigger headroom is a suitable solution or if we should remove the timing assertion all together.

@bryan-aguilar bryan-aguilar added the help wanted Extra attention is needed label Nov 9, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 29, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants