Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generated code from cmd/otecontribcol or cmd/otetestbedcol #27850

Closed
Tracked by #27826
dmitryax opened this issue Oct 18, 2023 · 7 comments · Fixed by #34844
Closed
Tracked by #27826

Remove generated code from cmd/otecontribcol or cmd/otetestbedcol #27850

dmitryax opened this issue Oct 18, 2023 · 7 comments · Fixed by #34844
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 18, 2023 •
edited
Loading

Don't need to keep the generated code. We can keep the builder yaml manifests only, and generate the code when it's needed.

  1. Find a better place for the collector builder yaml manifests
  2. Update all the CI steps and make targets to generate the code before building artifacts
  3. Remove the cmd/otecontribcol or cmd/otetestbedcol modules
@dmitryax dmitryax mentioned this issue Oct 18, 2023
Open
2 tasks
@dmitryax dmitryax changed the title Update CI to generate code for otecontribcol or otetestbedcol code before building the artifacts Remove generated code from cmd/otecontribcol or cmd/otetestbedcol Oct 18, 2023
@dmitryax dmitryax added help wanted Extra attention is needed ci-cd CI, CD, testing, build issues labels Oct 18, 2023
@crobert-1 crobert-1 mentioned this issue Oct 19, 2023
Merged
dmitryax pushed a commit that referenced this issue Oct 19, 2023
@crobert-1
[chore][cmd/otelcontribcol] Exclude from linter (#27865)
1e793c7 
**Description:**
The linter runs are taking longer and longer as more components and
dependencies are added, it's preferable to simply run on each individual
component.

**Link to tracking Issue:** 
Related: #27850
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this issue Oct 20, 2023
@crobert-1 @martin-majlis-s1
[chore][cmd/otelcontribcol] Exclude from linter (open-telemetry#27865)
4f7e853 
**Description:**
The linter runs are taking longer and longer as more components and
dependencies are added, it's preferable to simply run on each individual
component.

**Link to tracking Issue:** 
Related: open-telemetry#27850
@crobert-1 crobert-1 mentioned this issue Oct 20, 2023
Merged
codeboten pushed a commit that referenced this issue Oct 20, 2023
@crobert-1
[chore][cmd/oteltestbedcol] Skip linting generated code (#27884)
1f49a72 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Same idea as #27865, remove generated code from being linted. The linter
is taking longer and longer to run as more components and dependencies
are added. This change is to remove unnecessary modules from being
linted, which will help reduce runtime and resources required.

**Link to tracking Issue:** <Issue number if applicable>
Related #27850
@github-actions github-actions bot mentioned this issue Oct 24, 2023
Closed
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@crobert-1 @sigilioso
[chore][cmd/otelcontribcol] Exclude from linter (open-telemetry#27865)
ff03765 
**Description:**
The linter runs are taking longer and longer as more components and
dependencies are added, it's preferable to simply run on each individual
component.

**Link to tracking Issue:** 
Related: open-telemetry#27850
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@crobert-1 @sigilioso
[chore][cmd/oteltestbedcol] Skip linting generated code (open-telemet…
0f43f40 
…ry#27884)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Same idea as open-telemetry#27865, remove generated code from being linted. The linter
is taking longer and longer to run as more components and dependencies
are added. This change is to remove unnecessary modules from being
linted, which will help reduce runtime and resources required.

**Link to tracking Issue:** <Issue number if applicable>
Related open-telemetry#27850
@dmitryax dmitryax mentioned this issue Nov 1, 2023
Merged
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@crobert-1 @jmsnll
[chore][cmd/otelcontribcol] Exclude from linter (open-telemetry#27865)
194ba5a 
**Description:**
The linter runs are taking longer and longer as more components and
dependencies are added, it's preferable to simply run on each individual
component.

**Link to tracking Issue:** 
Related: open-telemetry#27850
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@crobert-1 @jmsnll
[chore][cmd/oteltestbedcol] Skip linting generated code (open-telemet…
045efdd 
…ry#27884)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Same idea as open-telemetry#27865, remove generated code from being linted. The linter
is taking longer and longer to run as more components and dependencies
are added. This change is to remove unnecessary modules from being
linted, which will help reduce runtime and resources required.

**Link to tracking Issue:** <Issue number if applicable>
Related open-telemetry#27850
This was referenced Dec 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] move azureeventhub receiver to generated lifecycle tests (ope…
761ff86 
…n-telemetry#30023)

Related to
open-telemetry#27850
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] move span processor to generated lifecycle tests (open-teleme…
c5443bf 
…try#30006)

Related to
open-telemetry#27850
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] move tcplog receiver to generated lifecycle tests (open-telem…
4aaf1c2 
…etry#29981)

Related to
open-telemetry#27850
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] move kafkareceiver to generated lifecycle tests (open-telemet…
3a9cfbd 
…ry#29946)

Related to
open-telemetry#27850
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] move logstransform processor to generated lifecycle tests (op…
b0cd650 
…en-telemetry#30017)

Related to
open-telemetry#27850
@adrielp adrielp mentioned this issue Feb 2, 2024
Merged
codeboten pushed a commit that referenced this issue Feb 2, 2024
@adrielp
[chore] add generated lifecycle tests (#31012)
29ecc62 
Add the lifecycle config to metadata.yaml and generate lifecycle tests.

Related to #27850
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Feb 19, 2024
@dmitryax dmitryax added needs triage New item requiring triage never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Mar 3, 2024
This was referenced Mar 5, 2024
Closed
Open
Closed
This was referenced Mar 19, 2024
Closed
Open
Closed
@atoulme atoulme removed the needs triage New item requiring triage label Mar 30, 2024
@mowies mowies mentioned this issue Aug 26, 2024
Merged
@mowies
Copy link
Member

mowies commented Aug 28, 2024

I started working on this, draft PR is open but still in progress.

@dmitryax what about the test files found in cmd/otelcontribcol?
Also, I will maybe have to keep the dockerfiles to build images of the collector that are needed in the pipeline.

@mowies
Copy link
Member

mowies commented Sep 9, 2024

@dmitryax any updates on this?

@mowies
Copy link
Member

mowies commented Sep 16, 2024

maybe somebody else from @open-telemetry/collector-contrib-maintainers ?

@mowies
Copy link
Member

mowies commented Sep 17, 2024

or @atoulme since you worked in removing things here as well?

jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mowies @jriguera
[chore] remove generated code (open-telemetry#34844)
4ae841e 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@mowies @AkhigbeEromo
[chore] remove generated code (open-telemetry#34844)
d895eae 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] remove generated code dynatrace-oss-contrib/opentelemetry-collector-contrib
4 participants
@atoulme @codeboten @dmitryax @mowies