Func Concat doesn't accept output of Split

[Pwalne]

Component(s)

processor/transform

What happened?

Description

The OTL func Concat complains that the output from a func Split is not StringLIkeGetter

Steps to Reproduce

Use transformprocessor to adjust attribute values (or a UUID)

Expected Result

Setting the value of attribute["a"] to the split and then rejoined string.

Actual Result

doesnt work; throws error if you try to pass a value from an attribute.

Collector version

0.87.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

processors:
  transform:
    trace_statements:
      -context: span
        statements:
          - set(attributes["a"], Concat(Split(attributes["a"],"-"),""))

Log output

error while parsing arguments for call to "set": invalid argument at position 1: error while parsing arguments for call to "Concat": invalid argument at position 0: must be a list of type StringLIkeGetter

Additional context

No response

[github-actions]

Pinging code owners:

• processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[TylerHelmuth]

Oh thats interesting. Since OTTL Converters don't have an associated Return Type yet, the grammar doesn't recognize that a Converter could be a valid input for the list it is expecting. In fact, the Concat currently needs a literal list, so you must supply [] in the statement, which means it wouldn't accept a list value from an attribute either.

I think we need to adjust the input type to be something like a ListGetter[T], where T is the type of the thing in the list. Probably needs touched up to handle the list type being a StringLikeGetter.

[TylerHelmuth]

For your needs though, you probably want to do

processors:
  transform:
    trace_statements:
      -context: span
        statements:
          - replace_pattern(attributes["a"], "-", "")

[Pwalne]

For your needs though, you probably want to do

processors:
  transform:
    trace_statements:
      -context: span
        statements:
          - replace_pattern(attributes["a"], "-", "")

Yes, I ended up doing something like that. Although in our scenerio we have todo something such as:

processors:
  transform:
    trace_statements:
      -context: span
        statements:
          -set(attributes["a"], attributes["b"])
          - replace_pattern(attributes["a"], "-", "")
          - set(trace_id.string, attributes["a"])
          - delete(atributes, "a")

And this is only because most UUID libraries encode with - and the trace/spanId do not like it.

[TylerHelmuth]

Have you tried doing set(trace_id.string, attributes["b"])? I thought it would handle the -.

[Pwalne]

Have you tried doing set(trace_id.string, attributes["b"])? I thought it would handle the -.

It doesn't as that was the first thing i tried. It complains its not 32 hex characters. But if I replace the - it works fine. This uuid generator module used is https://github.com/google/uuid

[TylerHelmuth]

I experimented for a bit today on what it would take so that Concat could accept the output of Split and my conclusion is that it is doable, but complicated.

[TylerHelmuth]

OTTL is working as expected right now tho - to allow this type of behavior would be a new feature.

[Pwalne]

Would it be easier to allow the traceId/spanId to parse - when used in transformation? Most uuid libraries encode the string value with it anyway

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[obs-gh-enricogiorio]

I also have issues with Concat. I am trying to concat this array: https://github.com/kubernetes/api/blob/master/core/v1/types.go#L5510, which is essentially a []string in go.
And I get the following error:

error: invalid configuration: processors::transform/object: unable to parse OTTL statement "set(attributes[\"ipFamilies\"], Concat(body[\"spec\"][\"ipFamilies\"], \",\"))": error while parsing arguments for call to "set": invalid argument at position 1: error while parsing arguments for call to "Concat": invalid argument at position 0: must be a list of type StringLikeGetter[github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottllog.TransformContext]

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.