Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Can we have CSI information as Resource Attributes of k8s.volume.* metrics? #27580

Closed
haihh05 opened this issue Oct 10, 2023 · 6 comments

Comments

@haihh05
Copy link

haihh05 commented Oct 10, 2023

Component(s)

receiver/kubeletstats

Is your feature request related to a problem? Please describe.

I would like to use OTEL with receiver/kubeletstats instead of kube-state-metrics for K8s monitoring, but I need some csi information.
In my current K8s, I had ceph cluster for k8s storage, then I can map csi_volume_handle to the image in ceph to get I/O metrics of each pv on k8s.
I believe that we will need that if we use the external storage.

Describe the solution you'd like

It is nice to have csi_volume_handle and csi_drive labels (like kube_persistentvolume_info metric in kube-state-metrics)

Describe alternatives you've considered

No response

Additional context

No response

@haihh05 haihh05 added enhancement New feature or request needs triage New item requiring triage labels Oct 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

Sounds like a reasonable addition as optional attributes. @haihh05 do you want to contribute and add them?

@haihh05
Copy link
Author

haihh05 commented Oct 10, 2023

Thanks, @dmitryax. I will think about it. But now I have no idea where I need to start from.

@TylerHelmuth TylerHelmuth added priority:p2 Medium and removed needs triage New item requiring triage labels Oct 10, 2023
@jinja2
Copy link
Contributor

jinja2 commented Oct 12, 2023

I think this would be a useful addition. Fwiw, the 3 k8s in-tree volume sources, AWSElasticBlockStore, GCEPersistentDisk and GlusterFs, we support right now were deprecated a few versions ago, and the recommendation is to use their corresponding CSI equivalent provisioners. So fetching the csi specific attributes would be useful for the more common managed distros (eks/gke/aks) too.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 11, 2023
Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants