Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/kafka] move kafka configures authentication to internal pkg #27093

Closed
sakulali opened this issue Sep 25, 2023 · 2 comments
Closed

[exporter/kafka] move kafka configures authentication to internal pkg #27093

sakulali opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request exporter/kafka

Comments

@sakulali
Copy link
Contributor

sakulali commented Sep 25, 2023

Component(s)

exporter/kafka

Is your feature request related to a problem? Please describe.

Function kafkaexporter.ConfigureAuthentication is referenced by the kafkametricsreceiver and kafkareceiver packages as shown below. We can extract that and place it in an internal package so that the references become clearer.
Additionally, we can fix this error when use checkapi tool(go run cmd/checkapi/main.go .):

2023/09/25 15:37:17 exporter/kafkaexporter has more than one function: "ConfigureAuthentication,NewFactory,WithLogsMarshalers,WithMetricsMarshalers,WithTracesMarshalers"
exit status 1

image

Describe the solution you'd like

Before the adjustment, the directory structure:
exporter/kafkaexporter
├── authentication.go
├── authentication_test.go
├── internal
│ ├── awsmsk
│ │ ├── doc.go
│ │ ├── iam_scram_client.go
│ │ └── iam_scram_client_test.go
├── scram_client.go

After the adjustment, the directory structure (add new directory internal/kafka):
internal/kafka
├── Makefile
├── authentication.go
├── authentication_test.go
├── awsmsk
│ ├── doc.go
│ ├── iam_scram_client.go
│ └── iam_scram_client_test.go
├── go.mod
├── go.sum
├── metadata.yaml
└── scram_client.go

Describe alternatives you've considered

No response

Additional context

No response

@sakulali sakulali added enhancement New feature or request needs triage New item requiring triage labels Sep 25, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@pavolloffay
Copy link
Member

+1

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 25, 2023
dmitryax pushed a commit that referenced this issue Oct 9, 2023
…#27289)

**Description:** 
Move kafka configures authentication to internal pkg, make references
become clearer. Additionally, avoid to use export function
`kafkaexporter.ConfigureAuthentication` to pass checkapi.

**Link to tracking Issue:** 

#27093
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
…open-telemetry#27289)

**Description:** 
Move kafka configures authentication to internal pkg, make references
become clearer. Additionally, avoid to use export function
`kafkaexporter.ConfigureAuthentication` to pass checkapi.

**Link to tracking Issue:** 

open-telemetry#27093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/kafka
Projects
None yet
Development

No branches or pull requests

3 participants