Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/aerospike/aerospike-client-go/v6 from 6.13.0 to 6.14.0 causes issues #26265

Closed
codeboten opened this issue Aug 29, 2023 · 17 comments
Assignees
Labels
dependencies Pull requests that update a dependency file go-1.21 Requires go 1.21 never stale Issues marked with this label will be never staled and automatically removed receiver/aerospike

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/aerospike

Describe the issue you're reporting

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6015671753/job/16318410285?pr=26262 for more details:

go: downloading github.com/mattn/go-sqlite3 v2.0.3+incompatible
mkdir -p /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit
go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~
panic: proto: file "rpc/rpc.proto" has a name conflict over DEFAULT
	previously from: "github.com/aerospike/aerospike-client-go/v6/proto/kvs"
	currently from:  "github.com/checkpoint-restore/go-criu/v5/rpc"
See https://protobuf.dev/reference/go/faq#namespace-conflict
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@antonblock
Copy link
Contributor

aerospike/aerospike-client-go#414

@crobert-1
Copy link
Member

crobert-1 commented Aug 31, 2023

Looks like this is a valid issue in the dependency so I'll remove the needs-triage label.

@crobert-1
Copy link
Member

/label -needs-triage

@djaglowski
Copy link
Member

I'll take a look at this.

@djaglowski
Copy link
Member

@dwelch-spike, any ideas?

@dwelch-spike
Copy link
Contributor

@djaglowski I'll bring the proto name issue up with the Go client developer, @khaf.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

I think this will get resolved with #30261, which requires use to bump our go version to 1.21

@khaf
Copy link

khaf commented Jan 23, 2024

I'll try to backport most of the Aerospike Go Client v7 changeset to the v6. Hopefully that will resolve this ticket.

@djaglowski djaglowski added the go-1.21 Requires go 1.21 label Jan 24, 2024
@khaf
Copy link

khaf commented Jan 25, 2024

This issue should be addressed in the Aerospike Go Client v6.15.0. Let me know how it goes.

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Jan 25, 2024

PR that does the bump: #30785

@djaglowski
Copy link
Member

Seems there may be a problem with the updated library. From CI failure on #30785:

panic: proto: file "kv.proto" has a name conflict over DEFAULT
	previously from: "github.com/checkpoint-restore/go-criu/v5/rpc"
	currently from:  "github.com/aerospike/aerospike-client-go/v6/proto/kvs"
See https://protobuf.dev/reference/go/faq#namespace-conflict

@khaf
Copy link

khaf commented Jan 27, 2024

I now see what's going on. The manifest used for the Aerospike Proxy Server does not state a package name, in effect using the Global Namespace. That's unfortunate, since it is not in my control. I'll ask my colleagues to address the issue. In the mean time, I'll see if I can provide a flag to exclude the Proxy server during build.

@TylerHelmuth
Copy link
Member

@khaf got the same error when using v7: #31270

@TylerHelmuth
Copy link
Member

Still experiencing problems with bumps to v6.15.1 and v7.4.0 after configschema was removed:

@djaglowski
Copy link
Member

Closing in favor of #34244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment