Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add Trace context to each span (Total Duration and Trace Group) #24975

Closed
amosd92 opened this issue Aug 7, 2023 · 3 comments

Comments

@amosd92
Copy link

amosd92 commented Aug 7, 2023

Component(s)

No response

Is your feature request related to a problem? Please describe.

When trying to solve a performance issue or an availability issue, I want to be able to look for spans with their TRACE context so that I can better filter and understand what is going on.

Use-cases (in query phase):
Filter spans from a specific operation where the full trace took more than 1s.
Filter for all spans with status code 500 and easily see what the parent span operation is and what triggers the span I was looking at

Today, we can store traces in multiple storage engines like OpenSearch, Cassandra, etc. We want to avoid running complex queries regardless of the storage engine.

Describe the solution you'd like

Add to every span two fields:
trace_duration
trace_group

Describe alternatives you've considered

This capability exists in "Data Prepper" of OpenSearch and was considered, but it happens after SpanMetrics connector.

Additional context

https://github.com/opensearch-project/data-prepper/blob/main/docs/trace_analytics.md#processor
It actually called Otel_trace_group processor

@crobert-1
Copy link
Member

crobert-1 commented Sep 6, 2023

I believe it would be best to file this against the specification repository, as this request is relevant to the underlying data model, not the collector or its components.

Otherwise, have you tried to use the attributes processor to accomplish this for your use case? There's a chance it might be able to do this.

@crobert-1
Copy link
Member

I'm going to close this issue for now, but feel free to reach out if I misunderstood something here.

@crobert-1 crobert-1 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
@amosd92
Copy link
Author

amosd92 commented Oct 30, 2023

Thank you for the feedback,
I will give the processor a go.
The reason I added it here is that it will probably be a bit faster to implement, given the tail base sample capabilities to work with a "full" trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants