Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] No system attributes set if host.id cannot be fetched #24669

Closed
dmitryax opened this issue Jul 28, 2023 · 1 comment · Fixed by #24670
Closed
Assignees
Labels
bug Something isn't working priority:p1 High processor/resourcedetection Resource detection processor

Comments

@dmitryax
Copy link
Member

dmitryax commented Jul 28, 2023

Component(s)

No response

What happened?

After #24239, instead of setting empty host.id, we started throwing an error and dropping all other important system detector attributes: host.name, os.type, host.arch.

We need set other system resources even if host.id cannot be fetched.

Also, it's happening even if the host.id is disabled, which is now the default behavior. open-telemetry/opentelemetry-collector#10901 will solve this particular issue. But it's not as important as this one.

Collector version

0.82.0 (binaries are not released yet)

@dmitryax dmitryax added bug Something isn't working needs triage New item requiring triage labels Jul 28, 2023
@dmitryax dmitryax changed the title [processor/resourcedetectio [processor/resourcedetection] No system attributes if host.id cannot be fetched Jul 28, 2023
@dmitryax dmitryax changed the title [processor/resourcedetection] No system attributes if host.id cannot be fetched [processor/resourcedetection] No system attributes set if host.id cannot be fetched Jul 28, 2023
@dmitryax dmitryax self-assigned this Jul 28, 2023
@dmitryax dmitryax added priority:p1 High processor/resourcedetection Resource detection processor and removed needs triage New item requiring triage labels Jul 28, 2023
@github-actions
Copy link
Contributor

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 High processor/resourcedetection Resource detection processor
Projects
None yet
1 participant