Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/{dockerstatsreceiver, kubeletstatsreceiver}] Collision with metric container.memory.rss #24009

Closed
mackjmr opened this issue Jul 6, 2023 · 7 comments

Comments

@mackjmr
Copy link
Member

mackjmr commented Jul 6, 2023

Component(s)

receiver/dockerstats, receiver/kubeletstats

Describe the issue you're reporting

Both dockerstatsreceiver and kubeletstatsreceiver emit metric with same name container.memory.rss.

I believe one should be renamed to avoid the collision.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

crobert-1 commented Sep 6, 2023

From the spec, metrics should never have the same name, so this is a valid issue.

Links to duplicate metric names:
dockerstats
kubeletstats

@crobert-1 crobert-1 added bug Something isn't working and removed Stale needs triage New item requiring triage labels Sep 6, 2023
@crobert-1
Copy link
Member

crobert-1 commented Sep 7, 2023

My apologies, from comments on #24229 it looks like this may be a more complicated situation than I assumed.

The outcome of this bug will be determined by the decision on #26499.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 7, 2023
@crobert-1 crobert-1 removed the Stale label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants