Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/filelog] Support for Multiple Current Sorted Files #23788

Closed
Mrod1598 opened this issue Jun 27, 2023 · 4 comments
Closed

[receiver/filelog] Support for Multiple Current Sorted Files #23788

Mrod1598 opened this issue Jun 27, 2023 · 4 comments
Labels
enhancement New feature or request receiver/filelog Stale

Comments

@Mrod1598
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

Another potential issue is the presence of multiple active files within a sorted group. It would be beneficial to have an option to specify the number of files at the top of the sorted list that should be considered as active.

Describe the solution you'd like

Introduce an additional field named 'top_n' to the ordering criteria. This field would allow users to specify the number of files to be considered from the top of the sorted list.

Describe alternatives you've considered

No response

Additional context

This is an additional feature that could be added as a follow on to: #22998
@Mrod1598 Mrod1598 added enhancement New feature or request needs triage New item requiring triage labels Jun 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski removed the needs triage New item requiring triage label Jun 27, 2023
@djaglowski djaglowski mentioned this issue Jun 28, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@djaglowski djaglowski removed the Stale label Aug 28, 2023
@djaglowski djaglowski mentioned this issue Oct 17, 2023
Closed
@BinaryFissionGames BinaryFissionGames mentioned this issue Oct 18, 2023
Merged
djaglowski pushed a commit that referenced this issue Oct 18, 2023
@BinaryFissionGames
[receiver/filelog] Implement specifying top n files to track when ord…
c44ad3c 
…ering (#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** #23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this issue Oct 20, 2023
@BinaryFissionGames @martin-majlis-s1
[receiver/filelog] Implement specifying top n files to track when ord…
23da457 
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@BinaryFissionGames @sigilioso
[receiver/filelog] Implement specifying top n files to track when ord…
5557590 
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 30, 2023
@djaglowski
Copy link
Member

Closed by #27844

jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@BinaryFissionGames @jmsnll
[receiver/filelog] Implement specifying top n files to track when ord…
e437f90 
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/filelog Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djaglowski @Mrod1598