-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to add instrumentation scope name as a dimension #23662
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Still relevant, nothing has changed. |
This sounds like a valid request to me, we'd essentially just be copying instrumentation scope from the incoming traces to the scope of the outgoing metrics. The configuration may need another look to match the style of existing options. It's usually something like Are you interested in adding this enhancement? |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Still relevant, nothing has changed. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
connector/spanmetrics
Is your feature request related to a problem? Please describe.
In my current project, I need the instrumentation scope name as a dimension in the exported span metrics.
Describe the solution you'd like
Ideally, a new option
instrumentation_scope
that allows you to configure which part of the scope should be included as a dimension:Additionally,
dimensions
should also look at the instrumentation scope attributes.Describe alternatives you've considered
Alternative, I'd have to add the name of the instrumentation scope to the span's attributes before it's send to the collector and then use the
dimensions
option. This isn't ideal, since every span would now have an additional tag.Additional context
No response
The text was updated successfully, but these errors were encountered: