Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/k8sattributesprocessor] Add resource_attributes group in metadata.yaml. #23152

Closed
Tracked by #22997
mackjmr opened this issue Jun 6, 2023 · 1 comment
Closed
Tracked by #22997

[processor/k8sattributesprocessor] Add resource_attributes group in metadata.yaml. #23152

mackjmr opened this issue Jun 6, 2023 · 1 comment
Assignees
@mackjmr
Labels
cmd/mdatagen mdatagen command processor/k8sattributes k8s Attributes processor

Comments

@mackjmr
Copy link
Member

mackjmr commented Jun 6, 2023

Component(s)

cmd/mdatagen, processor/k8sattributes

Describe the issue you're reporting

The group resource_attributes was introduced in the following PR.

Seeing that the k8sattributesprocessor already supports enabling/disabling the resource via a different configuration interface, the work here is adding the attributes to the metadata.yaml and documenting that these are exposed through a different configuration interface (as discussed here).
@mackjmr mackjmr added the needs triage New item requiring triage label Jun 6, 2023
@github-actions github-actions bot added processor/k8sattributes k8s Attributes processor cmd/mdatagen mdatagen command labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mackjmr mackjmr mentioned this issue Jun 6, 2023
Closed
2 tasks
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Jun 7, 2023
@mackjmr
processor/k8sattributes: Add resource_attributes to metadata.yaml
43c0d45 
This PR adds the resource attributes added by the k8sattributes processor to the metadata.yaml file in the resource_attributes group. Only the attributes which are added by default (see [documentation](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.79.0/processor/k8sattributesprocessor#configuration)) are marked as enabled.

The generated config structs are not used, as resource attributes are exposed through a different configuration interface. This is noted in the metadata.yaml file.

Fixes: open-telemetry#23152.
@mackjmr mackjmr mentioned this issue Jun 7, 2023
Merged
@songy23 songy23 removed the needs triage New item requiring triage label Jun 7, 2023
@mackjmr mackjmr closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mackjmr mackjmr

Labels
cmd/mdatagen mdatagen command processor/k8sattributes k8s Attributes processor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@songy23 @mackjmr