Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/receivercreator] Make documentation clear on the effects of using the receiver across different signals #23014

Closed
atoulme opened this issue Jun 1, 2023 · 5 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Jun 1, 2023

Component(s)

receiver/receivercreator

Is your feature request related to a problem? Please describe.

See #19641 (comment)

Describe the solution you'd like

We should make sure the documentation is accompanied by a few examples to clarify the use case of using the receivercreator across different signals.

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Jun 1, 2023
@atoulme atoulme removed the needs triage New item requiring triage label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@theletterf
Copy link
Member

@atoulme Happy to help. I indeed got wrong the part about the Collector crashing. What I understand now from the previous PR is that a receiver instantiated in pipelines with incompatible telemetry types might not crash when they should?

We need to get the following clear:

  • Why this is an issue, in practical terms.
  • What are the conditions for this to happen.
  • How can this be avoided or mitigated.

The existing note only partially covers the second item.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 2, 2023
@dmitryax dmitryax removed the Stale label Aug 11, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 11, 2023
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants