Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor: add resource_attributes group in metadata.yaml files #22997

Closed
2 tasks done
mackjmr opened this issue Jun 1, 2023 · 7 comments
Closed
2 tasks done

processor: add resource_attributes group in metadata.yaml files #22997

mackjmr opened this issue Jun 1, 2023 · 7 comments
Assignees
Labels
cmd/mdatagen mdatagen command enhancement New feature or request processor/k8sattributes k8s Attributes processor processor/resourcedetection Resource detection processor

Comments

@mackjmr
Copy link
Member

mackjmr commented Jun 1, 2023

Component(s)

k8sattributesprocessor, resourcedetectionprocessor

Describe the issue you're reporting

The group resource_attributes was introduced in the following PR.

As of today, no processors use the resource_attributes group and its generated config structs. What I'm proposing is adding the resource_attributes to processors where this is relevant:

@mackjmr mackjmr added the needs triage New item requiring triage label Jun 1, 2023
@mackjmr
Copy link
Member Author

mackjmr commented Jun 1, 2023

cc @dmitryax and @atoulme as you worked on the PR which added the ability to generate configs for resource attributes.

@mx-psi mx-psi added cmd/mdatagen mdatagen command and removed needs triage New item requiring triage labels Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi mx-psi added enhancement New feature or request processor/k8sattributes k8s Attributes processor processor/resourcedetection Resource detection processor labels Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Pinging code owners for processor/k8sattributes: @dmitryax @rmfitzpatrick @fatsheep9146. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented Jun 1, 2023

@mackjmr we already have an issue for resource detection processor #21482 which is in progress.

K8s attribute processor supports enabling/disabling the resource via a different configuration interface:

    extract:
      metadata:
        - k8s.namespace.name
        - k8s.node.name
        - k8s.pod.name
        - k8s.pod.uid
        - container.id
        - container.image.name
        - container.image.tag
      annotations:
        ...
      labels:
        ...

Not sure we should change it, it'll like be less intuitive, but we definitely can leverage the metadata.yaml with a comment that it's exposed through a different configuration interface. Feel free to submit an issue and work on it

@mackjmr
Copy link
Member Author

mackjmr commented Jun 5, 2023

Not sure we should change it, it'll like be less intuitive, but we definitely can leverage the metadata.yaml with a comment that it's exposed through a different configuration interface.

@dmitryax this approach makes sense to me, will open a separate issue specific to K8s attribute processor 👍

@mackjmr
Copy link
Member Author

mackjmr commented Jun 6, 2023

Opened an issue here, and linked it in the checkbox in the issue description. Will put up the PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen mdatagen command enhancement New feature or request processor/k8sattributes k8s Attributes processor processor/resourcedetection Resource detection processor
Projects
None yet
Development

No branches or pull requests

3 participants