-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor: add resource_attributes group in metadata.yaml files #22997
Comments
Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for processor/k8sattributes: @dmitryax @rmfitzpatrick @fatsheep9146. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@mackjmr we already have an issue for resource detection processor #21482 which is in progress. K8s attribute processor supports enabling/disabling the resource via a different configuration interface:
Not sure we should change it, it'll like be less intuitive, but we definitely can leverage the metadata.yaml with a comment that it's exposed through a different configuration interface. Feel free to submit an issue and work on it |
@dmitryax this approach makes sense to me, will open a separate issue specific to K8s attribute processor 👍 |
Opened an issue here, and linked it in the checkbox in the issue description. Will put up the PR as well. |
Component(s)
k8sattributesprocessor, resourcedetectionprocessor
Describe the issue you're reporting
The group
resource_attributes
was introduced in the following PR.As of today, no processors use the
resource_attributes
group and its generated config structs. What I'm proposing is adding theresource_attributes
to processors where this is relevant:The text was updated successfully, but these errors were encountered: